Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26556

An improper locking bug(s) due to unreleased lock

Details

    Description

      Hi, developers, thank you for your checking. It seems the lock lock_bigbuffer is not released correctly when big_buffer == NULL in the function log_statement_ex?

      https://github.com/MariaDB/server/blob/57f14eab20ae2733eb341f3d293515a10a40bc48/plugin/server_audit/server_audit.c#L1838-L1848

      Thank you for your checking!

      Attachments

        Issue Links

          links to

          Web Link CVE-2022-31624

          Activity

            Ascending order - Click to sort in descending order
            Ryan Ryan created issue -
            Ryan Ryan added a comment -

            Similarly, the lock archive_ctxt->mutex is not released correctly when archive_ctxt->dest_file == NULL in the function archive_open?

            https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_archive.cc#L168-L175

            Ryan Ryan added a comment - Similarly, the lock archive_ctxt->mutex is not released correctly when archive_ctxt->dest_file == NULL in the function archive_open ? https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_archive.cc#L168-L175
            Ryan Ryan made changes -
            Field Original Value New Value
            Summary An improper locking bug due to unreleased lock An improper locking bug(s) due to unreleased lock
            Ryan Ryan added a comment -

            the lock stream_ctxt->mutex is not released correctly when stream_ctxt->dest_file == NULL in the function xbstream_open
            https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_xbstream.cc#L126-L133

            Ryan Ryan added a comment - the lock stream_ctxt->mutex is not released correctly when stream_ctxt->dest_file == NULL in the function xbstream_open https://github.com/MariaDB/server/blob/76f4a78ba2639b5abd01a88b24a3c509c11530ce/extra/mariabackup/ds_xbstream.cc#L126-L133
            danblack Daniel Black made changes -
            Fix Version/s 10.2 [ 14601 ]
            danblack Daniel Black added a comment -

            on audit plugin - dates back to original commit - https://github.com/MariaDB/server/commit/cc84ac3be41d9d6ac480d55449d5bf4e324cca10

            xtrabackup too - https://github.com/MariaDB/server/commit/d7714308e014a7335e1c0f60dc0afbf5eba5ff99

            Ryan can to report a bug to percona too - https://github.com/percona/percona-xtrabackup/blob/8.0/storage/innobase/xtrabackup/src/ds_xbstream.cc#L124

            and before you go too far, a single bug report per instance would help to documented the fixed version as they may be different.

            danblack Daniel Black added a comment - on audit plugin - dates back to original commit - https://github.com/MariaDB/server/commit/cc84ac3be41d9d6ac480d55449d5bf4e324cca10 xtrabackup too - https://github.com/MariaDB/server/commit/d7714308e014a7335e1c0f60dc0afbf5eba5ff99 Ryan can to report a bug to percona too - https://github.com/percona/percona-xtrabackup/blob/8.0/storage/innobase/xtrabackup/src/ds_xbstream.cc#L124 and before you go too far, a single bug report per instance would help to documented the fixed version as they may be different.
            danblack Daniel Black made changes -
            Assignee Alexey Bychko [ abychko ]
            elenst Elena Stepanova made changes -
            Assignee Alexey Bychko [ abychko ] Alexey Botchkov [ holyfoot ]
            Ryan Ryan added a comment -

            @danblack@holyfoot Thank you very much for your checking.

            Ok, I would create more bug reports to let a bug report per instance to help to document the fixed version.

            Ryan Ryan added a comment - @danblack@holyfoot Thank you very much for your checking. Ok, I would create more bug reports to let a bug report per instance to help to document the fixed version.
            holyfoot Alexey Botchkov made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            holyfoot Alexey Botchkov made changes -
            Fix Version/s 10.2.41 [ 26032 ]
            Fix Version/s 10.2 [ 14601 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            danblack Daniel Black added a comment -

            holyfoot are the mariabackup fixes coming too? Or are those going to be put into a separate bug report?

            danblack Daniel Black added a comment - holyfoot are the mariabackup fixes coming too? Or are those going to be put into a separate bug report?
            Ryan Ryan added a comment - - edited

            Could you please also take a look at other similar issues I reported? Thanks

            MDEV-26561
            MDEV-26558
            MDEV-26560

            Ryan Ryan added a comment - - edited Could you please also take a look at other similar issues I reported? Thanks MDEV-26561 MDEV-26558 MDEV-26560
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 124866 ] MariaDB v4 [ 159667 ]
            serg Sergei Golubchik made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.6.5 [ 26034 ]
            Fix Version/s 10.5.13 [ 26026 ]
            Fix Version/s 10.4.22 [ 26031 ]
            Fix Version/s 10.3.32 [ 26029 ]

            People

              holyfoot Alexey Botchkov
              Ryan Ryan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.