Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26534

Missing install_spider.sql in 10.5-10.7 & various related items

    XMLWordPrintable

    Details

      Description

      The manual (https://mariadb.com/kb/en/spider-installation/) states:

      Note: If you're running a source code distribution of MariaDB, (that is, where you compiled it from source), the script is located in the build directory at storage/spider/scripts/install_spider.sql.
      

      The reality is different. In a directory which contains compiled versions of 10.2 to 10.7, we see this:

      $ ls -ld MD*
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.2.41-linux-x86_64-dbg
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.2.41-linux-x86_64-opt
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.3.32-linux-x86_64-dbg
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.3.32-linux-x86_64-opt
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.4.22-linux-x86_64-dbg
      drwxrwxr-x 14 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.4.22-linux-x86_64-opt
      drwxrwxr-x 13 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.5.13-linux-x86_64-dbg
      drwxrwxr-x 13 roel roel  4096 Aug 30 23:22 MD160821-mariadb-10.5.13-linux-x86_64-opt
      drwxrwxr-x 12 roel roel  4096 Aug 17 21:42 MD280621-mariadb-10.6.3-linux-x86_64-dbg
      drwxrwxr-x 12 roel roel 32768 Aug 17 21:42 MD280621-mariadb-10.6.3-linux-x86_64-opt
      drwxrwxr-x 13 roel roel  4096 Aug 10 20:08 MD260721-mariadb-10.6.4-linux-x86_64-dbg
      drwxrwxr-x 13 roel roel  4096 Aug 16 12:01 MD260721-mariadb-10.6.4-linux-x86_64-opt
      drwxrwxr-x 13 roel roel  4096 Aug 30 23:21 MD160821-mariadb-10.6.5-linux-x86_64-dbg
      drwxrwxr-x 13 roel roel 12288 Aug 30 23:22 MD160821-mariadb-10.6.5-linux-x86_64-opt
      drwxrwxr-x 13 roel roel  4096 Sep  4 06:54 MD280821-mariadb-10.7.0-linux-x86_64-dbg
      drwxrwxr-x 13 roel roel  4096 Aug 30 23:21 MD280821-mariadb-10.7.0-linux-x86_64-opt
       
      $ find . | grep 'install_spider'
      ./MD160821-mariadb-10.2.41-linux-x86_64-opt/share/install_spider.sql
      ./MD160821-mariadb-10.2.41-linux-x86_64-dbg/share/install_spider.sql
      ./MD160821-mariadb-10.3.32-linux-x86_64-opt/share/install_spider.sql
      ./MD160821-mariadb-10.3.32-linux-x86_64-dbg/share/install_spider.sql
      ./MD160821-mariadb-10.4.22-linux-x86_64-opt/share/install_spider.sql
      ./MD160821-mariadb-10.4.22-linux-x86_64-dbg/share/install_spider.sql
      

      10.5 to 10.7 have no install_spider.sql.

      Note also that the path for 10.2 to 10.4 is different from what was indicated in the manual (which is the source code path, not the resulting compiled package path). This may be acceptable, but it would need to be clarified in the manual.

      Confirming that the file is not in the source: pulled sources 10.2 to 10.7 (into 10.x):

      $ find . | grep '/10.[2-7]' | grep 'install_spider' 
      ./10.4/storage/spider/scripts/install_spider.sql
      ./10.2/storage/spider/scripts/install_spider.sql
      ./10.3/storage/spider/scripts/install_spider.sql
      

      If the installation method changed in 10.5, or if the file is no longer required, the manual requires updating with a version specific note and the priority would be critical.

      Furthermore, the manual states "Running this configuration script also creates a series of new tables in the mysql database, including:" ... "spider_xa_failed_log MariaDB 10.0.5" - i.e. it has a specific connection between the script and 10.5.

      Looking further, unrelated to the above, as of 10.5, postinst also was removed (may be an issue):

      $ find . | grep "mariadb-plugin-spider"
      ./10.2/debian/mariadb-plugin-spider.install
      ./10.2/debian/mariadb-plugin-spider.postinst
      ./10.3/debian/mariadb-plugin-spider.install
      ./10.3/debian/mariadb-plugin-spider.postinst
      ./10.4/debian/mariadb-plugin-spider.install
      ./10.4/debian/mariadb-plugin-spider.postinst
      ./10.5/debian/mariadb-plugin-spider.install
      ./10.6/debian/mariadb-plugin-spider.install
      ./10.7/debian/mariadb-plugin-spider.install
      

      I also noticed the install script became a lot smaller in 10.4:

      $ ls -l ./*/storage/spider/scripts/install_spider.sql
      -rw-rw-r-- 1 roel roel 15313 Sep  4 07:22 ./10.2/storage/spider/scripts/install_spider.sql
      -rw-rw-r-- 1 roel roel 23314 Sep  4 07:22 ./10.3/storage/spider/scripts/install_spider.sql
      -rw-rw-r-- 1 roel roel  1722 Sep  4 07:22 ./10.4/storage/spider/scripts/install_spider.sql
      

      On a positive note, lib/plugin/ha_spider.so was available in all versions.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              jacob.moorman Jacob Moorman
              Reporter:
              Roel Roel Van de Paar
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:

                  Git Integration