Type:
Task
Priority:
Major
Resolution:
Won't Do
We do see the following anywhere in the Spider codebase.
if (str->reserve(SPIDER_SQL_WHERE_LEN))
DBUG_RETURN(HA_ERR_OUT_OF_MEM);
str->q_append(SPIDER_SQL_WHERE_STR, SPIDER_SQL_WHERE_LEN);
This is messy and makes the code less readable. It would be better if we could write like this:
if ( int err = str->append(SPIDER_SQL_WHERE_STR))
DBUG_RETURN(err);
// multiple string can be appended at once
if ( int err = str->append(SPIDER_SQL_IN_STR, SPIDER_SQL_OPEN_PAREN_STR))
DBUG_RETURN(err);
The memory allocation should be automatically done in the append function. This automatic memory allocation should care about the performance. Possibly, it would allocate extra memory and reallocate memory only when it is necessary.
relates to
MDEV-27684
Spider: remove pattern str->reserve() then str->q_append()
Stalled
{"report":{"fcp":894.7000002861023,"ttfb":166.30000019073486,"pageVisibility":"visible","entityId":102001,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"f9de3da0-ddef-4c52-aba1-e3b94c2a02f2","navigationType":0,"readyForUser":1054.9000000953674,"redirectCount":0,"resourceLoadedEnd":1083.8000001907349,"resourceLoadedStart":172.80000019073486,"resourceTiming":[{"duration":49.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":172.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":172.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":222.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":49.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":173,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":173,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":222.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":116.39999961853027,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":173.2000002861023,"connectEnd":173.2000002861023,"connectStart":173.2000002861023,"domainLookupEnd":173.2000002861023,"domainLookupStart":173.2000002861023,"fetchStart":173.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":173.2000002861023,"responseEnd":289.59999990463257,"responseStart":289.59999990463257,"secureConnectionStart":173.2000002861023},{"duration":391.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":173.40000009536743,"connectEnd":173.40000009536743,"connectStart":173.40000009536743,"domainLookupEnd":173.40000009536743,"domainLookupStart":173.40000009536743,"fetchStart":173.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":173.40000009536743,"responseEnd":565,"responseStart":565,"secureConnectionStart":173.40000009536743},{"duration":396,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":173.59999990463257,"connectEnd":173.59999990463257,"connectStart":173.59999990463257,"domainLookupEnd":173.59999990463257,"domainLookupStart":173.59999990463257,"fetchStart":173.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":173.59999990463257,"responseEnd":569.5999999046326,"responseStart":569.5999999046326,"secureConnectionStart":173.59999990463257},{"duration":396.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":173.80000019073486,"connectEnd":173.80000019073486,"connectStart":173.80000019073486,"domainLookupEnd":173.80000019073486,"domainLookupStart":173.80000019073486,"fetchStart":173.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":173.80000019073486,"responseEnd":570,"responseStart":570,"secureConnectionStart":173.80000019073486},{"duration":396.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":174,"connectEnd":174,"connectStart":174,"domainLookupEnd":174,"domainLookupStart":174,"fetchStart":174,"redirectEnd":0,"redirectStart":0,"requestStart":174,"responseEnd":570.5,"responseStart":570.5,"secureConnectionStart":174},{"duration":397.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":174.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":174.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":571.7000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":396.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":174.30000019073486,"connectEnd":174.30000019073486,"connectStart":174.30000019073486,"domainLookupEnd":174.30000019073486,"domainLookupStart":174.30000019073486,"fetchStart":174.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":174.30000019073486,"responseEnd":570.9000000953674,"responseStart":570.9000000953674,"secureConnectionStart":174.30000019073486},{"duration":397.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":174.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":174.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":571.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":396.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":174.59999990463257,"connectEnd":174.59999990463257,"connectStart":174.59999990463257,"domainLookupEnd":174.59999990463257,"domainLookupStart":174.59999990463257,"fetchStart":174.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":174.59999990463257,"responseEnd":571.5,"responseStart":571.5,"secureConnectionStart":174.59999990463257},{"duration":681.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":175.59999990463257,"connectEnd":175.59999990463257,"connectStart":175.59999990463257,"domainLookupEnd":175.59999990463257,"domainLookupStart":175.59999990463257,"fetchStart":175.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":175.59999990463257,"responseEnd":857.3000001907349,"responseStart":857.3000001907349,"secureConnectionStart":175.59999990463257},{"duration":734.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":175.59999990463257,"connectEnd":175.59999990463257,"connectStart":175.59999990463257,"domainLookupEnd":175.59999990463257,"domainLookupStart":175.59999990463257,"fetchStart":175.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":175.59999990463257,"responseEnd":910.4000000953674,"responseStart":910.4000000953674,"secureConnectionStart":175.59999990463257},{"duration":417.80000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":439,"connectEnd":439,"connectStart":439,"domainLookupEnd":439,"domainLookupStart":439,"fetchStart":439,"redirectEnd":0,"redirectStart":0,"requestStart":439,"responseEnd":856.8000001907349,"responseStart":856.8000001907349,"secureConnectionStart":439},{"duration":204.19999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":886.3000001907349,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":886.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1090.5,"responseStart":0,"secureConnectionStart":0},{"duration":174.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":909.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":909.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1083.5,"responseStart":0,"secureConnectionStart":0},{"duration":173.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":909.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":909.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1083.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":126.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":910.7000002861023,"connectEnd":910.7000002861023,"connectStart":910.7000002861023,"domainLookupEnd":910.7000002861023,"domainLookupStart":910.7000002861023,"fetchStart":910.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":910.7000002861023,"responseEnd":1037,"responseStart":1037,"secureConnectionStart":910.7000002861023},{"duration":135.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":911.3000001907349,"connectEnd":911.3000001907349,"connectStart":911.3000001907349,"domainLookupEnd":911.3000001907349,"domainLookupStart":911.3000001907349,"fetchStart":911.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":911.3000001907349,"responseEnd":1047.2000002861023,"responseStart":1047.2000002861023,"secureConnectionStart":911.3000001907349},{"duration":137.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/e0bf5781d46ea69fb123572974cf39de-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/js/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":911.8000001907349,"connectEnd":911.8000001907349,"connectStart":911.8000001907349,"domainLookupEnd":911.8000001907349,"domainLookupStart":911.8000001907349,"fetchStart":911.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":911.8000001907349,"responseEnd":1049.0999999046326,"responseStart":1049.0999999046326,"secureConnectionStart":911.8000001907349}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":21,"responseStart":166,"responseEnd":168,"domLoading":170,"domInteractive":1135,"domContentLoadedEventStart":1135,"domContentLoadedEventEnd":1180,"domComplete":1886,"loadEventStart":1886,"loadEventEnd":1888,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1099.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1100},{"name":"bigPipe.activity-panel-pipe-id.start","time":1100.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1102.7000002861023},{"name":"activityTabFullyLoaded","time":1190.5}],"measures":[],"correlationId":"c3b4b435428eb9","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":88,"dbReadsTimeInMs":11,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}