spider_db_mbase_util::open_item_func() is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
spider_db_mbase_util::open_item_func(Item_func *item_func, ...) breaks almost every time new Item_func::Functyp} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable -Wswitch.
Split the function into two different functions: one handles the case of str != NULL and the other handles the case of str == NULL.
NOTE: You don't need to make everything ideal at once, and it's impossible to do that with complex middleware like databases. Refactor only to the extent that you are sure it is safe to do so without additional unit tests.
Attachments
Issue Links
blocks
MDEV-29447SIGSEGV in spider_db_open_item_field and SIGSEGV in spider_db_print_item_type, on SELECT
Closed
relates to
MDEV-26208Add unit tests for spider_db_mbase_util::open_item_func()
Closed
MDEV-30504Further refactoring of spider_db_mbase_util::open_item_func
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added.
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added. If possible, I'd like to include unit tests for the function.
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added. If possible, I'd like to include unit tests for the function.
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added. If possible, I'd like to include unit tests for the function.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added. If possible, I'd like to include unit tests for the function.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* Split the function into two different functions: one handles the case of {{str != NULL}} and the other handles the case of {{str == NULL}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* Split the function into two different functions: one handles the case of {{str != NULL}} and the other handles the case of {{str == NULL}}.
* (other refactoring here)
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* Split the function into two different functions: one handles the case of {{str != NULL}} and the other handles the case of {{str == NULL}}.
* (other refactoring here)
NOTE: You don't need to make everything ideal at once, and it's impossible to do that with complex middleware like databases. Refactor only to the extent that you are sure it is safe to do so without additional unit tests.
Nayuta Yanagisawa (Inactive)
added a comment - serg Please review the following patch. I refactored a little conservatively. Actually, I tried further refactoring but I noticed that it was too dangerous. https://github.com/MariaDB/server/commit/fa8a4a33c71807f37429c70e358b46c1f0aaf7c2
Nayuta Yanagisawa (Inactive)
added a comment - - edited serg Let me replace the patch. Please review this one. https://github.com/MariaDB/server/commit/3836098c29ef1b7ff9d5fbde99b690eab73a0df1
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* {{spider_db_mbase_util::open_item_func(Item_func *item_func, ...)}} breaks almost every time new {{Item_func::Functype}} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable {{-Wswitch}}.
* Split the function into two different functions: one handles the case of {{str != NULL}} and the other handles the case of {{str == NULL}}.
* (other refactoring here)
NOTE: You don't need to make everything ideal at once, and it's impossible to do that with complex middleware like databases. Refactor only to the extent that you are sure it is safe to do so without additional unit tests.
{{spider_db_mbase_util::open_item_func()}} is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.
* -spider_db_mbase_util::open_item_func(Item_func *item_func, ...) breaks almost every time new Item_func::Functyp} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable \-Wswitch-.
* Split the function into two different functions: one handles the case of {{str != NULL}} and the other handles the case of {{str == NULL}}.
NOTE: You don't need to make everything ideal at once, and it's impossible to do that with complex middleware like databases. Refactor only to the extent that you are sure it is safe to do so without additional unit tests.
Task
Critical
MDEV-29447 SIGSEGV in spider_db_open_item_field and SIGSEGV in spider_db_print_item_type, on SELECT
serg Please review the following patch. I refactored a little conservatively. Actually, I tried further refactoring but I noticed that it was too dangerous. https://github.com/MariaDB/server/commit/fa8a4a33c71807f37429c70e358b46c1f0aaf7c2