Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26285

Refactor spider_db_mbase_util::open_item_func()

Details

    Description

      spider_db_mbase_util::open_item_func() is a so-called monster function. It is difficult to maintain while it is expected that we need to modify it when a new SQL function or a new func_type is added.

      • spider_db_mbase_util::open_item_func(Item_func *item_func, ...) breaks almost every time new Item_func::Functyp} is added (e.g., MDEV-24760, MDEV-24517). A possible solution would be removeing the default case and enable -Wswitch.
      • Split the function into two different functions: one handles the case of str != NULL and the other handles the case of str == NULL.

      NOTE: You don't need to make everything ideal at once, and it's impossible to do that with complex middleware like databases. Refactor only to the extent that you are sure it is safe to do so without additional unit tests.

      Attachments

        Issue Links

          Activity

            serg Please review the following patch. I refactored a little conservatively. Actually, I tried further refactoring but I noticed that it was too dangerous. https://github.com/MariaDB/server/commit/fa8a4a33c71807f37429c70e358b46c1f0aaf7c2

            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - serg Please review the following patch. I refactored a little conservatively. Actually, I tried further refactoring but I noticed that it was too dangerous. https://github.com/MariaDB/server/commit/fa8a4a33c71807f37429c70e358b46c1f0aaf7c2
            nayuta-yanagisawa Nayuta Yanagisawa (Inactive) added a comment - - edited serg Let me replace the patch. Please review this one. https://github.com/MariaDB/server/commit/3836098c29ef1b7ff9d5fbde99b690eab73a0df1
            ycp Yuchen Pei added a comment -

            Bumped priority as a refactoring will fix MDEV-29447.

            ycp Yuchen Pei added a comment - Bumped priority as a refactoring will fix MDEV-29447 .

            The review of this patch is done in MDEV-29447

            serg Sergei Golubchik added a comment - The review of this patch is done in MDEV-29447

            People

              serg Sergei Golubchik
              nayuta-yanagisawa Nayuta Yanagisawa (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.