I just noticed that extending page_compressed tables will still create sparse files. The following patch could almost fix it. In the middle hunk for fil_ibd_create(), we have a chicken-and-egg problem that needs to be addressed:
diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc
|
index c841eb79497..e8d36f24228 100644
|
--- a/storage/innobase/fil/fil0fil.cc
|
+++ b/storage/innobase/fil/fil0fil.cc
|
@@ -577,7 +577,7 @@ fil_space_extend_must_retry(
|
os_offset_t(FIL_IBD_FILE_INITIAL_SIZE << srv_page_size_shift));
|
|
*success = os_file_set_size(node->name, node->handle, new_size,
|
- space->is_compressed());
|
+ node->punch_hole == 1);
|
|
os_has_said_disk_full = *success;
|
if (*success) {
|
@@ -2034,7 +2034,9 @@ fil_ibd_create(
|
|
if (!os_file_set_size(
|
path, file,
|
- os_offset_t(size) << srv_page_size_shift, is_compressed)) {
|
+ os_offset_t(size) << srv_page_size_shift,
|
+ is_compressed /* FIXME: punch_hole==1 is set only after
|
+ node->find_metadata() below */)) {
|
*err = DB_OUT_OF_FILE_SPACE;
|
err_exit:
|
os_file_close(file);
|
diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc
|
index 16250928845..0f016ba5f98 100644
|
--- a/storage/innobase/log/log0recv.cc
|
+++ b/storage/innobase/log/log0recv.cc
|
@@ -841,7 +841,7 @@ bool recv_sys_t::recover_deferred(recv_sys_t::map::iterator &p,
|
goto fail;
|
if (!os_file_set_size(node->name, node->handle,
|
size * fil_space_t::physical_size(flags),
|
- space->is_compressed()))
|
+ node->punch_hole == 1))
|
{
|
space->release();
|
goto fail;
|
- relates to
-
MDEV-26029
Sparse files are inefficient on thinly provisioned storage
-
-
Closed
{"report":{"fcp":1674.0999999046326,"ttfb":557.5,"pageVisibility":"visible","entityId":101384,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"59ed0387-76a9-4993-b583-a5a769229643","navigationType":0,"readyForUser":1762.6999998092651,"redirectCount":0,"resourceLoadedEnd":2068.7999997138977,"resourceLoadedStart":575.9000000953674,"resourceTiming":[{"duration":508.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":575.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":575.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1084.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":508.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":576.2999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":576.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1084.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":572.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":576.5,"connectEnd":576.5,"connectStart":576.5,"domainLookupEnd":576.5,"domainLookupStart":576.5,"fetchStart":576.5,"redirectEnd":0,"redirectStart":0,"requestStart":576.5,"responseEnd":1148.5999999046326,"responseStart":1148.5999999046326,"secureConnectionStart":576.5},{"duration":715.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":576.6999998092651,"connectEnd":576.6999998092651,"connectStart":576.6999998092651,"domainLookupEnd":576.6999998092651,"domainLookupStart":576.6999998092651,"fetchStart":576.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":576.6999998092651,"responseEnd":1292.5,"responseStart":1292.5,"secureConnectionStart":576.6999998092651},{"duration":720.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":576.7999997138977,"connectEnd":576.7999997138977,"connectStart":576.7999997138977,"domainLookupEnd":576.7999997138977,"domainLookupStart":576.7999997138977,"fetchStart":576.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":576.7999997138977,"responseEnd":1296.9000000953674,"responseStart":1296.9000000953674,"secureConnectionStart":576.7999997138977},{"duration":718.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":578.9000000953674,"connectEnd":578.9000000953674,"connectStart":578.9000000953674,"domainLookupEnd":578.9000000953674,"domainLookupStart":578.9000000953674,"fetchStart":578.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":578.9000000953674,"responseEnd":1297.4000000953674,"responseStart":1297.2999997138977,"secureConnectionStart":578.9000000953674},{"duration":718.5999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":579.1999998092651,"connectEnd":579.1999998092651,"connectStart":579.1999998092651,"domainLookupEnd":579.1999998092651,"domainLookupStart":579.1999998092651,"fetchStart":579.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":579.1999998092651,"responseEnd":1297.7999997138977,"responseStart":1297.7999997138977,"secureConnectionStart":579.1999998092651},{"duration":734.2999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":579.4000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":579.4000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1313.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":718.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":581.1999998092651,"connectEnd":581.1999998092651,"connectStart":581.1999998092651,"domainLookupEnd":581.1999998092651,"domainLookupStart":581.1999998092651,"fetchStart":581.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":581.1999998092651,"responseEnd":1299.9000000953674,"responseStart":1299.9000000953674,"secureConnectionStart":581.1999998092651},{"duration":731.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":582,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":582,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1313.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":719.3000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":582.2999997138977,"connectEnd":582.2999997138977,"connectStart":582.2999997138977,"domainLookupEnd":582.2999997138977,"domainLookupStart":582.2999997138977,"fetchStart":582.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":582.2999997138977,"responseEnd":1301.5999999046326,"responseStart":1301.5999999046326,"secureConnectionStart":582.2999997138977},{"duration":1065.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":585.5999999046326,"connectEnd":585.5999999046326,"connectStart":585.5999999046326,"domainLookupEnd":585.5999999046326,"domainLookupStart":585.5999999046326,"fetchStart":585.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":585.5999999046326,"responseEnd":1651,"responseStart":1651,"secureConnectionStart":585.5999999046326},{"duration":1478.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":585.6999998092651,"connectEnd":585.6999998092651,"connectStart":585.6999998092651,"domainLookupEnd":585.6999998092651,"domainLookupStart":585.6999998092651,"fetchStart":585.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":585.6999998092651,"responseEnd":2064.199999809265,"responseStart":2064.199999809265,"secureConnectionStart":585.6999998092651},{"duration":313.6000003814697,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1340.7999997138977,"connectEnd":1340.7999997138977,"connectStart":1340.7999997138977,"domainLookupEnd":1340.7999997138977,"domainLookupStart":1340.7999997138977,"fetchStart":1340.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":1340.7999997138977,"responseEnd":1654.4000000953674,"responseStart":1654.4000000953674,"secureConnectionStart":1340.7999997138977},{"duration":419.40000009536743,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1666.7999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1666.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2086.199999809265,"responseStart":0,"secureConnectionStart":0},{"duration":374.2000002861023,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1691.2999997138977,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1691.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2065.5,"responseStart":0,"secureConnectionStart":0},{"duration":373.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1692.2999997138977,"connectEnd":1692.2999997138977,"connectStart":1692.2999997138977,"domainLookupEnd":1692.2999997138977,"domainLookupStart":1692.2999997138977,"fetchStart":1692.2999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":1692.2999997138977,"responseEnd":2065.699999809265,"responseStart":2065.699999809265,"secureConnectionStart":1692.2999997138977},{"duration":376,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1692.7999997138977,"connectEnd":1692.7999997138977,"connectStart":1692.7999997138977,"domainLookupEnd":1692.7999997138977,"domainLookupStart":1692.7999997138977,"fetchStart":1692.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":1692.7999997138977,"responseEnd":2068.7999997138977,"responseStart":2068.7999997138977,"secureConnectionStart":1692.7999997138977}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":330,"responseStart":557,"responseEnd":559,"domLoading":570,"domInteractive":2150,"domContentLoadedEventStart":2150,"domContentLoadedEventEnd":2194,"domComplete":2860,"loadEventStart":2860,"loadEventEnd":2860,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2087.199999809265},{"name":"bigPipe.sidebar-id.end","time":2088.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":2088.2999997138977},{"name":"bigPipe.activity-panel-pipe-id.end","time":2090.5999999046326},{"name":"activityTabFullyLoaded","time":2204.199999809265}],"measures":[],"correlationId":"50f7122e3b22cd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":166,"dbReadsTimeInMs":14,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}