Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-26166

Innodb : replace log_write_up_to(LSN_MAX,...) with log_buffer_flush_to_disk()

Details

    Description

      There are several functions in Innodb to write log flush up to highest current lsn.
      It needs to be cleaned up, we already have log_buffer_flush_to_disk() function.

      Also, our unconventional use of LSN_MAX as parameter to log_write_up_to(), for special purpose of writing/flushing up to highest current lsn, confused at least one Oracle MySQL developer, who claimed finding a bug, after adding incorrect assertion to the code.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          wlad Vladislav Vaintroub created issue -
          wlad Vladislav Vaintroub made changes -
          Field Original Value New Value
          Description There are several functions in Innodb to write log flush up to highest current lsn.
          It needs to be cleaned up, we already have log_buffer_flush_to_disk() function.

          Also, our unconventional use of LSN_MAX as parameter to log_write_up_to(), for special purpose of writing/flushing up to highest current lsn, confused an Oracle developer, who [claimed finding a bug in his blog , after adding incorrect assertion to the code. | https://translate.google.com/translate?hl=en&sl=ja&u=http://buildup-db.blogspot.com/2021/03/mariadb-105.html&prev=search&pto=aue]           		There are several functions in Innodb to write log flush up to highest current lsn.
          It needs to be cleaned up, we already have log_buffer_flush_to_disk() function.

          Also, our unconventional use of LSN_MAX as parameter to log_write_up_to(), for special purpose of writing/flushing up to highest current lsn, confused an Oracle MySQL developer, who [claimed finding a bug, after adding incorrect assertion to the code.| https://translate.google.com/translate?hl=en&sl=ja&u=http://buildup-db.blogspot.com/2021/03/mariadb-105.html&prev=search&pto=aue]
          wlad Vladislav Vaintroub made changes -
          Description There are several functions in Innodb to write log flush up to highest current lsn.
          It needs to be cleaned up, we already have log_buffer_flush_to_disk() function.

          Also, our unconventional use of LSN_MAX as parameter to log_write_up_to(), for special purpose of writing/flushing up to highest current lsn, confused an Oracle MySQL developer, who [claimed finding a bug, after adding incorrect assertion to the code.| https://translate.google.com/translate?hl=en&sl=ja&u=http://buildup-db.blogspot.com/2021/03/mariadb-105.html&prev=search&pto=aue]           		There are several functions in Innodb to write log flush up to highest current lsn.
          It needs to be cleaned up, we already have log_buffer_flush_to_disk() function.

          Also, our unconventional use of LSN_MAX as parameter to log_write_up_to(), for special purpose of writing/flushing up to highest current lsn, confused at least one Oracle MySQL developer, who [claimed finding a bug, after adding incorrect assertion to the code.| https://translate.google.com/translate?hl=en&sl=ja&u=http://buildup-db.blogspot.com/2021/03/mariadb-105.html&prev=search&pto=aue]
          wlad Vladislav Vaintroub made changes -
          issue.field.resolutiondate 2021-07-21 21:05:31.0 2021-07-21 21:05:31.697
          wlad Vladislav Vaintroub made changes -
          Fix Version/s 10.5.12 [ 26025 ]
          Fix Version/s 10.6.4 [ 26033 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 123532 ] MariaDB v4 [ 159518 ]

          People

            wlad Vladislav Vaintroub
            wlad Vladislav Vaintroub
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.