In MDEV-25743, the function dict_check_sys_tables() was simplified in such a way that the mini-transaction will not be committed and restarted during the loop. But, we failed to adjust the call that would advance the cursor position:
diff --git a/storage/innobase/dict/dict0load.cc b/storage/innobase/dict/dict0load.cc
|
index ac81de9a25c..db11f4ff003 100644
|
--- a/storage/innobase/dict/dict0load.cc
|
+++ b/storage/innobase/dict/dict0load.cc
|
@@ -834,7 +834,7 @@ static ulint dict_check_sys_tables()
|
|
for (const rec_t *rec = dict_startscan_system(&pcur, &mtr,
|
dict_sys.sys_tables);
|
- rec; rec = dict_getnext_system(&pcur, &mtr)) {
|
+ rec; rec = dict_getnext_system_low(&pcur, &mtr)) {
|
ulint len;
|
table_id_t table_id;
|
ulint space_id;
|
It is unclear to me why this would not cause failures much more often. The incorrect call would attempt to restore the persistent cursor position while we are already holding a latch on the page. Recursive S-latches are not supported and could lead to a hang. A hang should however not be possible, because the purge of history is not yet running at this point of time, and no other thread should be acquiring conflicting latches on the page.
- is caused by
-
MDEV-25743
Unnecessary copying of table names in InnoDB dictionary operations
-
-
Closed
There are no comments yet on this issue.
{"report":{"fcp":807.7999999821186,"ttfb":217.5,"pageVisibility":"visible","entityId":100743,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"46faa398-feed-49a7-ab5e-ac04588950b4","navigationType":0,"readyForUser":883.7999999821186,"redirectCount":0,"resourceLoadedEnd":901.6999999880791,"resourceLoadedStart":222.69999998807907,"resourceTiming":[{"duration":12.099999994039536,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":222.69999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":222.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":234.7999999821186,"responseStart":0,"secureConnectionStart":0},{"duration":13.099999994039536,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":223,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":223,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":236.09999999403954,"responseStart":0,"secureConnectionStart":0},{"duration":74.59999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":223.19999998807907,"connectEnd":223.19999998807907,"connectStart":223.19999998807907,"domainLookupEnd":223.19999998807907,"domainLookupStart":223.19999998807907,"fetchStart":223.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":223.19999998807907,"responseEnd":297.7999999821186,"responseStart":297.7999999821186,"secureConnectionStart":223.19999998807907},{"duration":131.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":223.40000000596046,"connectEnd":223.40000000596046,"connectStart":223.40000000596046,"domainLookupEnd":223.40000000596046,"domainLookupStart":223.40000000596046,"fetchStart":223.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":223.40000000596046,"responseEnd":354.5,"responseStart":354.5,"secureConnectionStart":223.40000000596046},{"duration":134.69999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":223.59999999403954,"connectEnd":223.59999999403954,"connectStart":223.59999999403954,"domainLookupEnd":223.59999999403954,"domainLookupStart":223.59999999403954,"fetchStart":223.59999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":223.59999999403954,"responseEnd":358.2999999821186,"responseStart":358.19999998807907,"secureConnectionStart":223.59999999403954},{"duration":134.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":223.90000000596046,"connectEnd":223.90000000596046,"connectStart":223.90000000596046,"domainLookupEnd":223.90000000596046,"domainLookupStart":223.90000000596046,"fetchStart":223.90000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":223.90000000596046,"responseEnd":358.69999998807907,"responseStart":358.69999998807907,"secureConnectionStart":223.90000000596046},{"duration":135,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":224,"connectEnd":224,"connectStart":224,"domainLookupEnd":224,"domainLookupStart":224,"fetchStart":224,"redirectEnd":0,"redirectStart":0,"requestStart":224,"responseEnd":359,"responseStart":359,"secureConnectionStart":224},{"duration":219.30000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":224.09999999403954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":224.09999999403954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":443.40000000596046,"responseStart":0,"secureConnectionStart":0},{"duration":135.09999999403954,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":224.40000000596046,"connectEnd":224.40000000596046,"connectStart":224.40000000596046,"domainLookupEnd":224.40000000596046,"domainLookupStart":224.40000000596046,"fetchStart":224.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":224.40000000596046,"responseEnd":359.5,"responseStart":359.5,"secureConnectionStart":224.40000000596046},{"duration":219.09999999403954,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":224.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":224.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":443.59999999403954,"responseStart":0,"secureConnectionStart":0},{"duration":135.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":224.69999998807907,"connectEnd":224.69999998807907,"connectStart":224.69999998807907,"domainLookupEnd":224.69999998807907,"domainLookupStart":224.69999998807907,"fetchStart":224.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":224.69999998807907,"responseEnd":360,"responseStart":360,"secureConnectionStart":224.69999998807907},{"duration":420.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":225.40000000596046,"connectEnd":225.40000000596046,"connectStart":225.40000000596046,"domainLookupEnd":225.40000000596046,"domainLookupStart":225.40000000596046,"fetchStart":225.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":225.40000000596046,"responseEnd":645.9000000059605,"responseStart":645.9000000059605,"secureConnectionStart":225.40000000596046},{"duration":535.7999999821186,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":225.5,"connectEnd":225.5,"connectStart":225.5,"domainLookupEnd":225.5,"domainLookupStart":225.5,"fetchStart":225.5,"redirectEnd":0,"redirectStart":0,"requestStart":225.5,"responseEnd":761.2999999821186,"responseStart":761.2999999821186,"secureConnectionStart":225.5},{"duration":191.60000002384186,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":454.7999999821186,"connectEnd":454.7999999821186,"connectStart":454.7999999821186,"domainLookupEnd":454.7999999821186,"domainLookupStart":454.7999999821186,"fetchStart":454.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":454.7999999821186,"responseEnd":646.4000000059605,"responseStart":646.4000000059605,"secureConnectionStart":454.7999999821186},{"duration":190.90000000596046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":710.7999999821186,"connectEnd":710.7999999821186,"connectStart":710.7999999821186,"domainLookupEnd":710.7999999821186,"domainLookupStart":710.7999999821186,"fetchStart":710.7999999821186,"redirectEnd":0,"redirectStart":0,"requestStart":710.7999999821186,"responseEnd":901.6999999880791,"responseStart":901.6999999880791,"secureConnectionStart":710.7999999821186},{"duration":185.90000000596046,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":802,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":802,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":987.9000000059605,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":42,"responseStart":217,"responseEnd":218,"domLoading":220,"domInteractive":938,"domContentLoadedEventStart":938,"domContentLoadedEventEnd":985,"domComplete":1216,"loadEventStart":1216,"loadEventEnd":1217,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":919},{"name":"bigPipe.sidebar-id.end","time":919.7999999821186},{"name":"bigPipe.activity-panel-pipe-id.start","time":920},{"name":"bigPipe.activity-panel-pipe-id.end","time":920.5},{"name":"activityTabFullyLoaded","time":992}],"measures":[],"correlationId":"c55998e2adcfbd","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":103,"dbReadsTimeInMs":13,"dbConnsTimeInMs":22,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}