Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-25689

metadata_table_reference_count, metadata_table_handles_closed are updated inconsistently; remove them

Details

    Description

      The counter MONITOR_TABLE_REFERENCE (metadata_table_reference_count) is inconsistent at least since this change in MySQL 5.7.10: the member function dict_table_t::release() does not decrement the counter. Only dict_table_close() would do it.

      Furthermore, it looks like the counter MONITOR_TABLE_CLOSE (metadata_table_handles_closed) is incremented unconditionally in ha_innobase::close(), while the call to increment MONITOR_TABLE_OPEN would be avoided if ha_innobase::open() returns an error earlier.

      Given that no bug was filed about these inconsistencies so far (MySQL Bug #75966 was filed by an Oracle employee and fixed in MySQL 8.0), it looks like these counters are not important to users and can be removed.

      The counter MONITOR_TABLE_OPEN (metadata_table_handles_opened) will be retained for now.

      Attachments

        Issue Links

          Activity

            marko Marko Mäkelä created issue -
            marko Marko Mäkelä made changes -
            Field Original Value New Value
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2021-05-17 07:02:42.0 2021-05-17 07:02:42.655
            marko Marko Mäkelä made changes -
            Fix Version/s 10.6.1 [ 24437 ]
            Fix Version/s 10.6 [ 24028 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 121891 ] MariaDB v4 [ 159287 ]

            People

              marko Marko Mäkelä
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.