Type:
Bug
Priority:
Major
Resolution:
Duplicate
Affects Version/s:
10.2.2 , 10.3.0 , 10.4.0 , 10.5.0 , 10.6.0
2022-01-21 Update
This problem was solved under terms of MDEV-25904
Old description
Field_string::cmp() seems to do unnecessary work trimming trailing spaces:
int Field_string::cmp( const uchar *a_ptr, const uchar *b_ptr) const
{
size_t a_len, b_len;
if (mbmaxlen() != 1)
{
size_t char_len= Field_string::char_length();
a_len= field_charset()->charpos(a_ptr, a_ptr + field_length, char_len);
b_len= field_charset()->charpos(b_ptr, b_ptr + field_length, char_len);
}
else
a_len= b_len= field_length;
/*
We have to remove end space to be able to compare multi-byte-characters
like in latin_de 'ae' and 0xe4
*/
return field_charset()->strnncollsp(a_ptr, a_len,
b_ptr, b_len);
}
In absolute majority cases, the difference between strings is found in the very beginning of the compared strings. So doing charpos() on the two arguments, before passing them to the actual comparison function, looks like an inefficient waste of CPU.
A better approach would be to implement a new comparison function with this tentative API:
int strnncollsp_nchars(CHARSET_INFO *cs,
const char *s1, size_t len1,
const char *s2, size_t len2,
size_t nchars);
Internally, the exact virtial implementations of strnncollsp_nchars() would do the same with what strnncollsp() do in the same collation, but with an extra limit on "nchars".
This new function should also help to fix a bug in the similar code in InnoDB: see MDEV-25440 for details.
{"report":{"fcp":872.7000000476837,"ttfb":238.5,"pageVisibility":"visible","entityId":98929,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":32,"apdex":1,"journeyId":"57144c89-b669-44b5-8c5e-0bbdd7dca17a","navigationType":0,"readyForUser":947.2000000476837,"redirectCount":0,"resourceLoadedEnd":894.7000000476837,"resourceLoadedStart":247,"resourceTiming":[{"duration":5.400000095367432,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":247,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":247,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":252.40000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":5.3999998569488525,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":247.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":247.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":252.70000004768372,"responseStart":0,"secureConnectionStart":0},{"duration":141.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":247.5,"connectEnd":247.5,"connectStart":247.5,"domainLookupEnd":247.5,"domainLookupStart":247.5,"fetchStart":247.5,"redirectEnd":0,"redirectStart":0,"requestStart":247.5,"responseEnd":389.40000009536743,"responseStart":389.40000009536743,"secureConnectionStart":247.5},{"duration":128.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":248,"connectEnd":248,"connectStart":248,"domainLookupEnd":248,"domainLookupStart":248,"fetchStart":248,"redirectEnd":0,"redirectStart":0,"requestStart":248,"responseEnd":376.7000000476837,"responseStart":376.7000000476837,"secureConnectionStart":248},{"duration":131.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":248.30000019073486,"connectEnd":248.30000019073486,"connectStart":248.30000019073486,"domainLookupEnd":248.30000019073486,"domainLookupStart":248.30000019073486,"fetchStart":248.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":248.30000019073486,"responseEnd":379.80000019073486,"responseStart":379.80000019073486,"secureConnectionStart":248.30000019073486},{"duration":10.400000095367432,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":248.40000009536743,"connectEnd":248.40000009536743,"connectStart":248.40000009536743,"domainLookupEnd":248.40000009536743,"domainLookupStart":248.40000009536743,"fetchStart":248.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":248.40000009536743,"responseEnd":258.80000019073486,"responseStart":258.80000019073486,"secureConnectionStart":248.40000009536743},{"duration":24.799999952316284,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":248.60000014305115,"connectEnd":248.60000014305115,"connectStart":248.60000014305115,"domainLookupEnd":248.60000014305115,"domainLookupStart":248.60000014305115,"fetchStart":248.60000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":248.60000014305115,"responseEnd":273.40000009536743,"responseStart":273.40000009536743,"secureConnectionStart":248.60000014305115},{"duration":38.299999952316284,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":248.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":248.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":287,"responseStart":0,"secureConnectionStart":0},{"duration":142.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":248.90000009536743,"connectEnd":248.90000009536743,"connectStart":248.90000009536743,"domainLookupEnd":248.90000009536743,"domainLookupStart":248.90000009536743,"fetchStart":248.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":248.90000009536743,"responseEnd":391.30000019073486,"responseStart":391.30000019073486,"secureConnectionStart":248.90000009536743},{"duration":142.89999985694885,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":249.10000014305115,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":249.10000014305115,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":392,"responseStart":0,"secureConnectionStart":0},{"duration":142.70000004768372,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":249.20000004768372,"connectEnd":249.20000004768372,"connectStart":249.20000004768372,"domainLookupEnd":249.20000004768372,"domainLookupStart":249.20000004768372,"fetchStart":249.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":249.20000004768372,"responseEnd":391.90000009536743,"responseStart":391.90000009536743,"secureConnectionStart":249.20000004768372},{"duration":177.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":275.30000019073486,"connectEnd":275.30000019073486,"connectStart":275.30000019073486,"domainLookupEnd":275.30000019073486,"domainLookupStart":275.30000019073486,"fetchStart":275.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":275.30000019073486,"responseEnd":452.90000009536743,"responseStart":452.90000009536743,"secureConnectionStart":275.30000019073486},{"duration":272.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":275.40000009536743,"connectEnd":275.40000009536743,"connectStart":275.40000009536743,"domainLookupEnd":275.40000009536743,"domainLookupStart":275.40000009536743,"fetchStart":275.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":275.40000009536743,"responseEnd":547.7000000476837,"responseStart":547.7000000476837,"secureConnectionStart":275.40000009536743},{"duration":125.29999995231628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":627.3000001907349,"connectEnd":627.3000001907349,"connectStart":627.3000001907349,"domainLookupEnd":627.3000001907349,"domainLookupStart":627.3000001907349,"fetchStart":627.3000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":627.3000001907349,"responseEnd":752.6000001430511,"responseStart":752.6000001430511,"secureConnectionStart":627.3000001907349},{"duration":141.39999985694885,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":845.6000001430511,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":845.6000001430511,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":987,"responseStart":0,"secureConnectionStart":0},{"duration":43.200000047683716,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":851.5,"connectEnd":851.5,"connectStart":851.5,"domainLookupEnd":851.5,"domainLookupStart":851.5,"fetchStart":851.5,"redirectEnd":0,"redirectStart":0,"requestStart":851.5,"responseEnd":894.7000000476837,"responseStart":894.7000000476837,"secureConnectionStart":851.5}],"fetchStart":0,"domainLookupStart":22,"domainLookupEnd":46,"connectStart":46,"connectEnd":65,"secureConnectionStart":54,"requestStart":65,"responseStart":239,"responseEnd":275,"domLoading":242,"domInteractive":1011,"domContentLoadedEventStart":1011,"domContentLoadedEventEnd":1048,"domComplete":1369,"loadEventStart":1369,"loadEventEnd":1369,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":989},{"name":"bigPipe.sidebar-id.end","time":989.7000000476837},{"name":"bigPipe.activity-panel-pipe-id.start","time":989.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.end","time":992.3000001907349},{"name":"activityTabFullyLoaded","time":1059.4000000953674}],"measures":[],"correlationId":"4c206bc67d1f8a","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":106,"dbReadsTimeInMs":15,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}