Type:
Task
Priority:
Major
Resolution:
Duplicate
mysqltest has a lot of historical problems:
ad hoc parser, weird limitations
commands added as needed with no view over the total language structure
historical code issues (e.g. casts that become unnecessary ~10 years ago)
etc
A lot can be done to improve it.
Ideas
to simplify writing tests
control structures, else in if , break and continue in while , for (or foreach ) loop
proper expression support in let , if , etc
letenv command to set environment variables instead of having let do it.
${var} and ${${var}} variable expansion
rich enough expressions to make resorting to sql unnecessary in most cases
in particular, see rpl_init.inc
remove unused and redundant commands (e.g. system vs exec , query_vertical vs vertical_results ONCE )
remove complex commands that do many sql statements under the hood, if they can be scripted, e.g. sync_slave_with_master
scoped variables
parameters for the source command
remove dead code
returning values from perl command (in some easier way than writing a new file and sourcing it)
e.g. stderr is stored in $perl ?
running many test files on one server connection. They are supposed to be independent, so for performance reasons we can avoid restarting mysqltest for them
to simplify debugging
make `echo` automatically print `#` at the start of every line (optionally, don't do it if it's explicitly specified — for backward compatibility)
make most commands print itself to the log.
os and file operations, like exec/remove_file, etc, should strip MYSQL_VAR_DIR from paths.
remove over-verbose treatment of rpl test failures (already done in 64dd3969481 )
is duplicated by
MDEV-12130
Improve mysqltest language
Open
{"report":{"fcp":838.7999999523163,"ttfb":152.79999995231628,"pageVisibility":"visible","entityId":98112,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"d37ca0aa-677b-4310-b747-f4a8c83b9740","navigationType":0,"readyForUser":892.0999999046326,"redirectCount":0,"resourceLoadedEnd":1155,"resourceLoadedStart":157.79999995231628,"resourceTiming":[{"duration":248.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":157.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":157.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":405.89999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":247.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":158.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":158.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":405.89999985694885,"responseStart":0,"secureConnectionStart":0},{"duration":258.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":158.09999990463257,"connectEnd":158.09999990463257,"connectStart":158.09999990463257,"domainLookupEnd":158.09999990463257,"domainLookupStart":158.09999990463257,"fetchStart":158.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":158.09999990463257,"responseEnd":416.39999985694885,"responseStart":416.39999985694885,"secureConnectionStart":158.09999990463257},{"duration":283,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":158.20000004768372,"connectEnd":158.20000004768372,"connectStart":158.20000004768372,"domainLookupEnd":158.20000004768372,"domainLookupStart":158.20000004768372,"fetchStart":158.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":158.20000004768372,"responseEnd":441.2000000476837,"responseStart":441.2000000476837,"secureConnectionStart":158.20000004768372},{"duration":286.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":158.29999995231628,"connectEnd":158.29999995231628,"connectStart":158.29999995231628,"domainLookupEnd":158.29999995231628,"domainLookupStart":158.29999995231628,"fetchStart":158.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":158.29999995231628,"responseEnd":445,"responseStart":445,"secureConnectionStart":158.29999995231628},{"duration":286.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":158.5,"connectEnd":158.5,"connectStart":158.5,"domainLookupEnd":158.5,"domainLookupStart":158.5,"fetchStart":158.5,"redirectEnd":0,"redirectStart":0,"requestStart":158.5,"responseEnd":445.2999999523163,"responseStart":445.2999999523163,"secureConnectionStart":158.5},{"duration":287.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":158.5,"connectEnd":158.5,"connectStart":158.5,"domainLookupEnd":158.5,"domainLookupStart":158.5,"fetchStart":158.5,"redirectEnd":0,"redirectStart":0,"requestStart":158.5,"responseEnd":445.7000000476837,"responseStart":445.7000000476837,"secureConnectionStart":158.5},{"duration":288.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":158.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":158.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":446.7000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":287.39999985694885,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":158.70000004768372,"connectEnd":158.70000004768372,"connectStart":158.70000004768372,"domainLookupEnd":158.70000004768372,"domainLookupStart":158.70000004768372,"fetchStart":158.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":158.70000004768372,"responseEnd":446.09999990463257,"responseStart":446.09999990463257,"secureConnectionStart":158.70000004768372},{"duration":288,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":158.79999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":158.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":446.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":287.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":158.89999985694885,"connectEnd":158.89999985694885,"connectStart":158.89999985694885,"domainLookupEnd":158.89999985694885,"domainLookupStart":158.89999985694885,"fetchStart":158.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":158.89999985694885,"responseEnd":446.7000000476837,"responseStart":446.7000000476837,"secureConnectionStart":158.89999985694885},{"duration":995.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":159.59999990463257,"connectEnd":159.59999990463257,"connectStart":159.59999990463257,"domainLookupEnd":159.59999990463257,"domainLookupStart":159.59999990463257,"fetchStart":159.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":159.59999990463257,"responseEnd":1154.7000000476837,"responseStart":1154.7000000476837,"secureConnectionStart":159.59999990463257},{"duration":995.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":159.70000004768372,"connectEnd":159.70000004768372,"connectStart":159.70000004768372,"domainLookupEnd":159.70000004768372,"domainLookupStart":159.70000004768372,"fetchStart":159.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":159.70000004768372,"responseEnd":1155,"responseStart":1155,"secureConnectionStart":159.70000004768372},{"duration":509.19999980926514,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":645.2000000476837,"connectEnd":645.2000000476837,"connectStart":645.2000000476837,"domainLookupEnd":645.2000000476837,"domainLookupStart":645.2000000476837,"fetchStart":645.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":645.2000000476837,"responseEnd":1154.3999998569489,"responseStart":1154.3999998569489,"secureConnectionStart":645.2000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":2,"responseStart":152,"responseEnd":154,"domLoading":155,"domInteractive":1178,"domContentLoadedEventStart":1178,"domContentLoadedEventEnd":1210,"domComplete":1988,"loadEventStart":1988,"loadEventEnd":1989,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1164.2999999523163},{"name":"bigPipe.sidebar-id.end","time":1165.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.start","time":1165.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1167.3999998569489},{"name":"activityTabFullyLoaded","time":1215.8999998569489}],"measures":[],"correlationId":"5ea88d63a15b2a","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":97,"dbReadsTimeInMs":12,"dbConnsTimeInMs":20,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}