[MDEV-24920] Merge "old" SQL variable to "old_mode" sql variable - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.9.1
Component/s: Variables
Labels:
- Preview_10.9
- beginner-friendly

Description

SQL variable "old" controls boolean server variable old_mode which used in several places.

SQL variable "old_mode" controls set server variable old_behavior.

Make so that SQL "old" variable will set one or several bits in "old_mode" (old_behavior) for compatibility.

Check knowledge base for correspondence description to server behavior (now there told that old_mode replace old but it does not looks like correct)

Attachments

Issue Links

is part of

MDEV-28112 prepare 10.9.0 preview releases

Closed

relates to

MDEV-28029 No warnings if server starts with "--old" option

Closed

Activity

Ascending order - Click to sort in descending order

Oleksandr Byelkin created issue - 2021-02-18 19:12

Oleksandr Byelkin made changes - 2021-02-18 19:13

Field	Original Value	New Value
Component/s		Variables [ 13903 ]
Component/s	Variables [ 15002 ]
Fix Version/s		10.6 [ 24028 ]
Fix Version/s	10.6 [ 24027 ]
Key	~~MENT-1108~~	~~MDEV-24920~~
Project	MariaDB Enterprise [ 11500 ]	MariaDB Server [ 10000 ]

Oleksandr Byelkin made changes - 2021-02-18 19:13

Assignee

Oleksandr Byelkin [ sanja ]

Rucha Deodhar [ rucha174 ]

Sergei Golubchik made changes - 2021-04-23 10:15

Labels

beginner-friendly

Sergei Golubchik made changes - 2021-04-23 10:15

Description

SQL variable "old" controls boolean server variable old_mode which used in several places.

SQL variable "old_mode" controls set server variable old_behavior.

Make so that SQL "old" valeable will set one or several bits in "old_mode" (old_behavior) for compatibility.

Check knowledge base for corespondence description to server behaviour (now there told that old_mode replace old but it does not looks like correct)

SQL variable "old" controls boolean server variable old_mode which used in several places.

SQL variable "old_mode" controls set server variable old_behavior.

Make so that SQL "old" variable will set one or several bits in "old_mode" (old_behavior) for compatibility.

Check knowledge base for correspondence description to server behavior (now there told that old_mode replace old but it does not looks like correct)

Sergei Golubchik made changes - 2021-06-22 17:31

Fix Version/s		10.7 [ 24805 ]
Fix Version/s	10.6 [ 24028 ]

Rucha Deodhar made changes - 2021-08-26 14:55

Status

Open [ 1 ]

Confirmed [ 10101 ]

Rucha Deodhar made changes - 2021-08-26 14:55

Status

Confirmed [ 10101 ]

In Progress [ 3 ]

Rucha Deodhar added a comment - 2021-08-26 14:56 - edited

Patch:
https://github.com/MariaDB/server/commit/71f2c6b710dad256b7f930c01bc6006ce7742f15
rebased on 10.9

Rucha Deodhar added a comment - 2021-08-26 14:56 - edited Patch: https://github.com/MariaDB/server/commit/71f2c6b710dad256b7f930c01bc6006ce7742f15 rebased on 10.9

Rucha Deodhar made changes - 2021-08-26 14:56

Assignee	Rucha Deodhar [ rucha174 ]	Oleksandr Byelkin [ sanja ]
Status	In Progress [ 3 ]	In Review [ 10002 ]

Oleksandr Byelkin made changes - 2021-09-14 08:52

Assignee	Oleksandr Byelkin [ sanja ]	Rucha Deodhar [ rucha174 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Rucha Deodhar made changes - 2021-09-14 16:07

Assignee	Rucha Deodhar [ rucha174 ]	Oleksandr Byelkin [ sanja ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Oleksandr Byelkin added a comment - 2021-10-05 12:32

Please change 2 things I mentions and give it Serg for review, because we change flags

Oleksandr Byelkin added a comment - 2021-10-05 12:32 Please change 2 things I mentions and give it Serg for review, because we change flags

Oleksandr Byelkin made changes - 2021-10-05 12:32

Assignee	Oleksandr Byelkin [ sanja ]	Rucha Deodhar [ rucha174 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Rucha Deodhar made changes - 2021-10-05 21:32

Assignee	Rucha Deodhar [ rucha174 ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Rucha Deodhar made changes - 2021-10-06 04:20

Assignee

Sergei Golubchik [ serg ]

Rucha Deodhar [ rucha174 ]

Rucha Deodhar made changes - 2021-10-06 04:20

Status

In Review [ 10002 ]

Stalled [ 10000 ]

Rucha Deodhar made changes - 2021-10-06 07:31

Assignee	Rucha Deodhar [ rucha174 ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Oleksandr Byelkin added a comment - 2021-10-06 07:55

7eff1b0b1f6c53f4f75aab5b45e533151d0beae9 looks OK for me (after changing 128->64)

Oleksandr Byelkin added a comment - 2021-10-06 07:55 7eff1b0b1f6c53f4f75aab5b45e533151d0beae9 looks OK for me (after changing 128->64)

Sergei Golubchik made changes - 2021-10-22 06:33

Fix Version/s		10.8 [ 26121 ]
Fix Version/s	10.7 [ 24805 ]

Sergei Golubchik made changes - 2021-12-06 21:22

Workflow

MariaDB v3 [ 119298 ]

MariaDB v4 [ 131779 ]

Sergei Golubchik made changes - 2022-01-10 18:51

Assignee	Sergei Golubchik [ serg ]	Rucha Deodhar [ rucha174 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Rucha Deodhar made changes - 2022-01-11 09:24

Fix Version/s		10.9 [ 26905 ]
Fix Version/s	10.8 [ 26121 ]

Rucha Deodhar made changes - 2022-01-11 11:57

Assignee	Rucha Deodhar [ rucha174 ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Sergei Golubchik made changes - 2022-03-02 19:50

Assignee	Sergei Golubchik [ serg ]	Rucha Deodhar [ rucha174 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Rucha Deodhar made changes - 2022-03-08 11:02

Assignee	Rucha Deodhar [ rucha174 ]	Sergei Golubchik [ serg ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Sergei Golubchik added a comment - 2022-03-08 12:45

71f2c6b710dad256b7f930c01bc60 is ok to push

Sergei Golubchik added a comment - 2022-03-08 12:45 71f2c6b710dad256b7f930c01bc60 is ok to push

Sergei Golubchik made changes - 2022-03-08 12:45

Assignee	Sergei Golubchik [ serg ]	Rucha Deodhar [ rucha174 ]
Status	In Review [ 10002 ]	Stalled [ 10000 ]

Rucha Deodhar added a comment - 2022-03-08 13:11

pushed to preview branch: https://github.com/MariaDB/server/tree/preview-10.9-MDEV-24920

Rucha Deodhar added a comment - 2022-03-08 13:11 pushed to preview branch: https://github.com/MariaDB/server/tree/preview-10.9-MDEV-24920

Rucha Deodhar made changes - 2022-03-08 13:11

Status

Stalled [ 10000 ]

In Progress [ 3 ]

Rucha Deodhar made changes - 2022-03-08 13:11

Status

In Progress [ 3 ]

In Testing [ 10301 ]

Rucha Deodhar made changes - 2022-03-08 13:11

Assignee

Rucha Deodhar [ rucha174 ]

Lena Startseva [ JIRAUSER50478 ]

Lena Startseva added a comment - 2022-03-09 06:24

Since the "-~~old" option is deprecated, I think it is need to change option "old" to "~~-old-mode" in tests. I found this option in tests "main.old-mode" (old-mode-master.opt) and "main.row-checksum-old" (row-checksum-old-master.opt).

Also the option "--old" is set next values for @@OLD_MODE:

SELECT @@OLD_MODE ;

+---------------------------------------------------------------------------------+

| @@OLD_MODE                                                                      |

+---------------------------------------------------------------------------------+

| NO_PROGRESS_INFO,UTF8_IS_UTF8MB3,IGNORE_INDEX_ONLY_FOR_JOIN,COMPAT_5_1_CHECKSUM |

+---------------------------------------------------------------------------------+

that not all are described in https://mariadb.com/kb/en/old-mode/ (e.g. "IGNORE_INDEX_ONLY_FOR_JOIN", "COMPAT_5_1_CHECKSUM"). It would be nice to update the documentation as well.

Lena Startseva added a comment - 2022-03-09 06:24 Since the "- old" option is deprecated, I think it is need to change option " old" to " -old-mode" in tests. I found this option in tests "main.old-mode" (old-mode-master.opt) and "main.row-checksum-old" (row-checksum-old-master.opt). Also the option "--old" is set next values for @@OLD_MODE: SELECT @@OLD_MODE ; +---------------------------------------------------------------------------------+ | @@OLD_MODE | +---------------------------------------------------------------------------------+ | NO_PROGRESS_INFO,UTF8_IS_UTF8MB3,IGNORE_INDEX_ONLY_FOR_JOIN,COMPAT_5_1_CHECKSUM | +---------------------------------------------------------------------------------+ that not all are described in https://mariadb.com/kb/en/old-mode/ (e.g. "IGNORE_INDEX_ONLY_FOR_JOIN", "COMPAT_5_1_CHECKSUM"). It would be nice to update the documentation as well.

Rucha Deodhar added a comment - 2022-03-09 09:31 - edited

lstartseva yes, updating KB shortly.

About some test still using --old , I didn't remove the option file to demonstrate the deprecation warning. --old currently also sets the corresponding old_mode variables so the rest of the test should work fine. Only new addition is that now it also gives warning.

Rucha Deodhar added a comment - 2022-03-09 09:31 - edited lstartseva yes, updating KB shortly. About some test still using --old , I didn't remove the option file to demonstrate the deprecation warning. --old currently also sets the corresponding old_mode variables so the rest of the test should work fine. Only new addition is that now it also gives warning.

Lena Startseva made changes - 2022-03-09 10:23

Link

This issue relates to ~~MDEV-28029~~ [ ~~MDEV-28029~~ ]

Sergei Golubchik made changes - 2022-03-17 10:18

Link

This issue is part of ~~MDEV-28112~~ [ ~~MDEV-28112~~ ]

Lena Startseva added a comment - 2022-03-28 03:49

Testing done, need to fix ~~MDEV-28029~~ before merging

Lena Startseva added a comment - 2022-03-28 03:49 Testing done, need to fix MDEV-28029 before merging

Lena Startseva made changes - 2022-03-28 03:49

Status

In Testing [ 10301 ]

Stalled [ 10000 ]

Lena Startseva made changes - 2022-03-28 03:49

Assignee

Lena Startseva [ JIRAUSER50478 ]

Rucha Deodhar [ rucha174 ]

Rucha Deodhar added a comment - 2022-04-20 06:06

Pushed to 10.9

Rucha Deodhar added a comment - 2022-04-20 06:06 Pushed to 10.9

Rucha Deodhar made changes - 2022-04-20 06:06

Fix Version/s		10.9.1 [ 27114 ]
Fix Version/s	10.9 [ 26905 ]
Resolution		Fixed [ 1 ]
Status	Stalled [ 10000 ]	Closed [ 6 ]

Ralf Gebhardt made changes - 2023-03-21 10:49

Labels

beginner-friendly

Preview_10.9 beginner-friendly

People

Assignee:: Rucha Deodhar

Reporter:: Oleksandr Byelkin

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 2021-02-18 19:12

Updated:: 2023-03-21 10:49

Resolved:: 2022-04-20 06:06

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration