[MDEV-24920] Merge "old" SQL variable to "old_mode" sql variable Created: 2021-02-18  Updated: 2023-03-21  Resolved: 2022-04-20

Status: Closed
Project: MariaDB Server
Component/s: Variables
Fix Version/s: 10.9.1

Type: Task Priority: Major
Reporter: Oleksandr Byelkin Assignee: Rucha Deodhar
Resolution: Fixed Votes: 0
Labels: Preview_10.9, beginner-friendly

Issue Links:
PartOf
is part of MDEV-28112 prepare 10.9.0 preview releases Closed
Relates
relates to MDEV-28029 No warnings if server starts with "--... Closed

 Description   

SQL variable "old" controls boolean server variable old_mode which used in several places.

SQL variable "old_mode" controls set server variable old_behavior.

Make so that SQL "old" variable will set one or several bits in "old_mode" (old_behavior) for compatibility.

Check knowledge base for correspondence description to server behavior (now there told that old_mode replace old but it does not looks like correct)

 Comments   
Comment by Rucha Deodhar [ 2021-08-26 ]

Patch:
https://github.com/MariaDB/server/commit/71f2c6b710dad256b7f930c01bc6006ce7742f15
rebased on 10.9

Comment by Oleksandr Byelkin [ 2021-10-05 ]

Please change 2 things I mentions and give it Serg for review, because we change flags

Comment by Oleksandr Byelkin [ 2021-10-06 ]

7eff1b0b1f6c53f4f75aab5b45e533151d0beae9 looks OK for me (after changing 128->64)

Comment by Sergei Golubchik [ 2022-03-08 ]

71f2c6b710dad256b7f930c01bc60 is ok to push

Comment by Rucha Deodhar [ 2022-03-08 ]

pushed to preview branch: https://github.com/MariaDB/server/tree/preview-10.9-MDEV-24920

Comment by Lena Startseva [ 2022-03-09 ]

Since the "-old" option is deprecated, I think it is need to change option "old" to "-old-mode" in tests. I found this option in tests "main.old-mode" (old-mode-master.opt) and "main.row-checksum-old" (row-checksum-old-master.opt).

Also the option "--old" is set next values for @@OLD_MODE:

SELECT @@OLD_MODE ;
 
+---------------------------------------------------------------------------------+
 
| @@OLD_MODE                                                                      |
 
+---------------------------------------------------------------------------------+
 
| NO_PROGRESS_INFO,UTF8_IS_UTF8MB3,IGNORE_INDEX_ONLY_FOR_JOIN,COMPAT_5_1_CHECKSUM |
 
+---------------------------------------------------------------------------------+

that not all are described in https://mariadb.com/kb/en/old-mode/ (e.g. "IGNORE_INDEX_ONLY_FOR_JOIN", "COMPAT_5_1_CHECKSUM"). It would be nice to update the documentation as well.

Comment by Rucha Deodhar [ 2022-03-09 ]

lstartseva yes, updating KB shortly.

About some test still using --old , I didn't remove the option file to demonstrate the deprecation warning. --old currently also sets the corresponding old_mode variables so the rest of the test should work fine. Only new addition is that now it also gives warning.

Comment by Lena Startseva [ 2022-03-28 ]

Testing done, need to fix MDEV-28029 before merging

Comment by Rucha Deodhar [ 2022-04-20 ]

Pushed to 10.9

Generated at Thu Feb 08 09:33:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.