Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24920

Merge "old" SQL variable to "old_mode" sql variable

Details

    Description

      SQL variable "old" controls boolean server variable old_mode which used in several places.

      SQL variable "old_mode" controls set server variable old_behavior.

      Make so that SQL "old" variable will set one or several bits in "old_mode" (old_behavior) for compatibility.

      Check knowledge base for correspondence description to server behavior (now there told that old_mode replace old but it does not looks like correct)

      Attachments

        Issue Links

          is part of

          Task - A task that needs to be done. MDEV-28112 prepare 10.9.0 preview releases

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28029 No warnings if server starts with "--old" option

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            rucha174 Rucha Deodhar added a comment - - edited

            Patch:
            https://github.com/MariaDB/server/commit/71f2c6b710dad256b7f930c01bc6006ce7742f15
            rebased on 10.9

            rucha174 Rucha Deodhar added a comment - - edited Patch: https://github.com/MariaDB/server/commit/71f2c6b710dad256b7f930c01bc6006ce7742f15 rebased on 10.9
            sanja Oleksandr Byelkin added a comment -

            Please change 2 things I mentions and give it Serg for review, because we change flags

            sanja Oleksandr Byelkin added a comment - Please change 2 things I mentions and give it Serg for review, because we change flags
            sanja Oleksandr Byelkin added a comment -

            7eff1b0b1f6c53f4f75aab5b45e533151d0beae9 looks OK for me (after changing 128->64)

            sanja Oleksandr Byelkin added a comment - 7eff1b0b1f6c53f4f75aab5b45e533151d0beae9 looks OK for me (after changing 128->64)
            serg Sergei Golubchik added a comment -

            71f2c6b710dad256b7f930c01bc60 is ok to push

            serg Sergei Golubchik added a comment - 71f2c6b710dad256b7f930c01bc60 is ok to push
            rucha174 Rucha Deodhar added a comment -

            pushed to preview branch: https://github.com/MariaDB/server/tree/preview-10.9-MDEV-24920

            rucha174 Rucha Deodhar added a comment - pushed to preview branch: https://github.com/MariaDB/server/tree/preview-10.9-MDEV-24920
            lstartseva Lena Startseva added a comment -

            Since the "-old" option is deprecated, I think it is need to change option "old" to "-old-mode" in tests. I found this option in tests "main.old-mode" (old-mode-master.opt) and "main.row-checksum-old" (row-checksum-old-master.opt).

            Also the option "--old" is set next values for @@OLD_MODE:

            SELECT @@OLD_MODE ;
            		 
            +---------------------------------------------------------------------------------+
            		 
            | @@OLD_MODE                                                                      |
            		 
            +---------------------------------------------------------------------------------+
            		 
            | NO_PROGRESS_INFO,UTF8_IS_UTF8MB3,IGNORE_INDEX_ONLY_FOR_JOIN,COMPAT_5_1_CHECKSUM |
            		 
            +---------------------------------------------------------------------------------+

            that not all are described in https://mariadb.com/kb/en/old-mode/ (e.g. "IGNORE_INDEX_ONLY_FOR_JOIN", "COMPAT_5_1_CHECKSUM"). It would be nice to update the documentation as well.

            lstartseva Lena Startseva added a comment - Since the "- old" option is deprecated, I think it is need to change option " old" to " -old-mode" in tests. I found this option in tests "main.old-mode" (old-mode-master.opt) and "main.row-checksum-old" (row-checksum-old-master.opt). Also the option "--old" is set next values for @@OLD_MODE: SELECT @@OLD_MODE ; +---------------------------------------------------------------------------------+ | @@OLD_MODE | +---------------------------------------------------------------------------------+ | NO_PROGRESS_INFO,UTF8_IS_UTF8MB3,IGNORE_INDEX_ONLY_FOR_JOIN,COMPAT_5_1_CHECKSUM | +---------------------------------------------------------------------------------+ that not all are described in https://mariadb.com/kb/en/old-mode/ (e.g. "IGNORE_INDEX_ONLY_FOR_JOIN", "COMPAT_5_1_CHECKSUM"). It would be nice to update the documentation as well.
            rucha174 Rucha Deodhar added a comment - - edited

            lstartseva yes, updating KB shortly.

            About some test still using --old , I didn't remove the option file to demonstrate the deprecation warning. --old currently also sets the corresponding old_mode variables so the rest of the test should work fine. Only new addition is that now it also gives warning.

            rucha174 Rucha Deodhar added a comment - - edited lstartseva yes, updating KB shortly. About some test still using --old , I didn't remove the option file to demonstrate the deprecation warning. --old currently also sets the corresponding old_mode variables so the rest of the test should work fine. Only new addition is that now it also gives warning.
            lstartseva Lena Startseva added a comment -

            Testing done, need to fix MDEV-28029 before merging

            lstartseva Lena Startseva added a comment - Testing done, need to fix MDEV-28029 before merging
            rucha174 Rucha Deodhar added a comment -

            Pushed to 10.9

            rucha174 Rucha Deodhar added a comment - Pushed to 10.9

            People

              rucha174 Rucha Deodhar
              sanja Oleksandr Byelkin
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.