[MDEV-24917] Flushing starts only when 90% (srv_max_buf_pool_modified_pct) pages are modified - Jira

XML

Word

Printable

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Critical
Resolution: Fixed
Affects Version/s: 10.6
Fix Version/s: 10.5.9
Component/s: Storage Engine - InnoDB
Labels:
- regression-10.5

Description

Recently changes in introduced by ~~MDEV-24537~~ accidentally changed the logic such that the flow will not start flushing pages till the number of the dirty-pages > srv_max_buf_pool_modified_pct (default 90%) when ideally is flushing should kick in when the dirty pages > 10%.

    if (lsn_limit);

****    else if (dirty_pct < srv_max_buf_pool_modified_pct)****

      goto unemployed;

    else if (srv_max_dirty_pages_pct_lwm == 0.0 ||

             dirty_pct < srv_max_dirty_pages_pct_lwm)

      goto unemployed;

Said condition is wrong and should be removed.

Attachments

Issue Links

is caused by

MDEV-24537 innodb_max_dirty_pages_pct_lwm=0 lost its special meaning

Closed

relates to

MDEV-24278 InnoDB page cleaner keeps waking up on idle server

Closed

MDEV-24369 Page cleaner sleeps indefinitely despite innodb_max_dirty_pages_pct_lwm being exceeded

Closed

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Krunal Bauskar

Votes:: 0 Vote for this issue

Watchers:: 3 Start watching this issue

Dates

Created:: 2021-02-18 12:42

Updated:: 2021-02-19 09:45

Resolved:: 2021-02-19 09:45

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.