Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24794

VALBLK::MoveNull does not make any changes

Details

    Description

      /storage/connect/valblk.h

                void   MoveNull(int i, int j)
      		 
                        {if (To_Nulls) To_Nulls[j] = To_Nulls[j];}

      Note, j is used as an index both times, so we copy To_Nulls value to itself instead of moving.
      Should be:

                void   MoveNull(int i, int j)
      		 
                        {if (To_Nulls) To_Nulls[j] = To_Nulls[i];}

      Attachments

        Issue Links

          links to

          Web Link Commit that introduced the issue

          Activity

            Ascending order - Click to sort in descending order
            imskr Shubham Kumar added a comment -

            Can I work on this?

            imskr Shubham Kumar added a comment - Can I work on this?
            anel Anel Husakovic added a comment -

            Suggested patch is good IMHO

            anel Anel Husakovic added a comment - Suggested patch is good IMHO
            bertrandop Olivier Bertrand added a comment -

            Thanks Anel.

            bertrandop Olivier Bertrand added a comment - Thanks Anel.

            People

              bertrandop Olivier Bertrand
              yury.chaikou Yury Chaikou
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.