[#MDEV-24794] VALBLK::MoveNull does not make any changes

[MDEV-24794] VALBLK::MoveNull does not make any changes Created: 2021-02-06 Updated: 2021-04-23 Resolved: 2021-04-05
Status:	Closed
Project:	MariaDB Server
Component/s:	Storage Engine - Connect
Affects Version/s:	N/A
Fix Version/s:	10.2.38, 10.3.29, 10.4.19, 10.5.10

Type:

Bug

Priority:

Minor

Reporter:

Yury Chaikou

Assignee:

Olivier Bertrand

Resolution:

Fixed

Votes:

Labels:

None

Description

/storage/connect/valblk.h

          void   MoveNull(int i, int j)

                  {if (To_Nulls) To_Nulls[j] = To_Nulls[j];}

Note, j is used as an index both times, so we copy To_Nulls value to itself instead of moving.
Should be:

          void   MoveNull(int i, int j)

                  {if (To_Nulls) To_Nulls[j] = To_Nulls[i];}

Comments

Comment by Shubham Kumar [ 2021-02-06 ]

Can I work on this?

Comment by Anel Husakovic [ 2021-04-05 ]

Suggested patch is good IMHO

Comment by Olivier Bertrand [ 2021-04-05 ]

Thanks Anel.

Generated at Thu Feb 08 09:32:43 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.