Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24794

VALBLK::MoveNull does not make any changes

Details

    Description

      /storage/connect/valblk.h

                void   MoveNull(int i, int j)
      		 
                        {if (To_Nulls) To_Nulls[j] = To_Nulls[j];}

      Note, j is used as an index both times, so we copy To_Nulls value to itself instead of moving.
      Should be:

                void   MoveNull(int i, int j)
      		 
                        {if (To_Nulls) To_Nulls[j] = To_Nulls[i];}

      Attachments

        Issue Links

          links to

          Web Link Commit that introduced the issue

          Activity

            Ascending order - Click to sort in descending order
            yury.chaikou Yury Chaikou created issue -
            yury.chaikou Yury Chaikou made changes -
            Field Original Value New Value
            imskr Shubham Kumar added a comment -

            Can I work on this?

            imskr Shubham Kumar added a comment - Can I work on this?
            elenst Elena Stepanova made changes -
            Component/s Storage Engine - Connect [ 10128 ]
            Fix Version/s 10.5 [ 23123 ]
            Assignee Anel Husakovic [ anel ]
            anel Anel Husakovic made changes -
            Description /storage/connect/valblk.h

                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}j{color}];}

            Note, j is used as an index both times, so we copy To_Nulls value to itself instead of moving.
            Should be:

                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}i{color}];}             		{{/storage/connect/valblk.h}}
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}j{color}];}
            {code}
            Note, {{j}} is used as an index both times, so we copy {{To_Nulls}} value to itself instead of moving.
            Should be:
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}i{color}];}
            {code}
            anel Anel Husakovic made changes -
            Description {{/storage/connect/valblk.h}}
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}j{color}];}
            {code}
            Note, {{j}} is used as an index both times, so we copy {{To_Nulls}} value to itself instead of moving.
            Should be:
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}i{color}];}
            {code}             		{{/storage/connect/valblk.h}}
            {code:noformat}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}j{color}];}
            {code}
            Note, {{j}} is used as an index both times, so we copy {{To_Nulls}} value to itself instead of moving.
            Should be:
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}i{color}];}
            {code}
            anel Anel Husakovic made changes -
            Description {{/storage/connect/valblk.h}}
            {code:noformat}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}j{color}];}
            {code}
            Note, {{j}} is used as an index both times, so we copy {{To_Nulls}} value to itself instead of moving.
            Should be:
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[{color:red}i{color}];}
            {code}             		{{/storage/connect/valblk.h}}
            {code:noformat}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[j];}
            {code}
            Note, {{j}} is used as an index both times, so we copy {{To_Nulls}} value to itself instead of moving.
            Should be:
            {code}
                      void MoveNull(int i, int j)
                              {if (To_Nulls) To_Nulls[j] = To_Nulls[i];}
            {code}
            anel Anel Husakovic made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            anel Anel Husakovic added a comment -

            Suggested patch is good IMHO

            anel Anel Husakovic added a comment - Suggested patch is good IMHO
            anel Anel Husakovic made changes -
            Assignee Anel Husakovic [ anel ] Olivier Bertrand [ bertrandop ]
            Status Confirmed [ 10101 ] In Review [ 10002 ]
            bertrandop Olivier Bertrand made changes -
            Affects Version/s N/A [ 14700 ]
            Affects Version/s 10.5 [ 23123 ]
            bertrandop Olivier Bertrand added a comment -

            Thanks Anel.

            bertrandop Olivier Bertrand added a comment - Thanks Anel.
            bertrandop Olivier Bertrand made changes -
            issue.field.resolutiondate 2021-04-05 18:16:42.0 2021-04-05 18:16:42.025
            bertrandop Olivier Bertrand made changes -
            Fix Version/s 10.2.38 [ 25207 ]
            Fix Version/s 10.3.29 [ 25206 ]
            Fix Version/s 10.4.19 [ 25205 ]
            Fix Version/s 10.5.10 [ 25204 ]
            Fix Version/s 10.6.1 [ 24437 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Fix Version/s 10.6.1 [ 24437 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 118870 ] MariaDB v4 [ 158865 ]

            People

              bertrandop Olivier Bertrand
              yury.chaikou Yury Chaikou
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.