Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24719

backport MDEV-24705 from 10.5 to 10.2, 10.3, 10.4

Details

    Description

      In 10.5 log records are parsed to find mtr commit LSN, then this LSN is stored in record object and used to compare it with FIL_PAGE_LSN, in 10.2 such preliminary parsing absent, and that is why there is nothing to compare. To fix it we need to implement such mtr commit LSN search for 10.2 too.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-12353 Efficient InnoDB redo log record format

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-24705 add check that LSN of the last skipped log record equals to FIL_PAGE_LSN field

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24197 Prepare step of backup failing on large backup

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25014 insert log record is not written for compressed row format

          • Major - Major loss of function.
          • Closed

          Activity

            marko Marko Mäkelä added a comment -

            In 10.5, stress tests of MDEV-24705 proved that MDEV-12353 guarantees that recovered pages will carry exactly the same FIL_PAGE_LSN as they would have if the server had not been killed.

            Before MDEV-12353, recovery would write to FIL_PAGE_LSN the end offset of the individual redo log record, instead of writing the mtr_t::commit_lsn(). Implementing the MDEV-24705 consistency check in older versions may involve some considerable execution time overhead. If benchmarks indicate that it is the case, the check might have to be disabled by default.

            marko Marko Mäkelä added a comment - In 10.5, stress tests of MDEV-24705 proved that MDEV-12353 guarantees that recovered pages will carry exactly the same FIL_PAGE_LSN as they would have if the server had not been killed. Before MDEV-12353 , recovery would write to FIL_PAGE_LSN the end offset of the individual redo log record, instead of writing the mtr_t::commit_lsn() . Implementing the MDEV-24705 consistency check in older versions may involve some considerable execution time overhead. If benchmarks indicate that it is the case, the check might have to be disabled by default.

            People

              vlad.lesin Vladislav Lesin
              vlad.lesin Vladislav Lesin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.