Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24526

binlog rotate via FLUSH LOGS may obsolate binlog file for recovery too early

Details

    Description

      There's a race between FLUSH LOGS and binlog-group commit for Binlog-checkpoint notification which must be done *after* the committed group transactions' affected
      data are flushed to disk. However the notification may happen before that fore the reason
      FLUSH LOGS handler does to acquire necessary mutexes.

      A test case follows with a patch to be committed soon.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24530 binlog-optimize-thread-scheduling=0 case of binlog rotate via FLUSH LOGS may obsolate binlog file too eary

          • Major - Major loss of function.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-24302 RESET MASTER hangs as Innodb does not report on binlog checkpoint

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28948 FLUSH BINARY LOGS waits/hangs on mysql_mutex_unlock(&LOCK_index) forever

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            Elkin Andrei Elkin added a comment -

            A relate issue is mentioned/linked.

            Elkin Andrei Elkin added a comment - A relate issue is mentioned/linked.
            Elkin Andrei Elkin added a comment -

            alice: We need to test this and MDEV-24302 (being committed shortly)
            patch in stress environment. I'll attach mtr test that attempts that, but it won't be added to the patch as we need some tens of minutes running load (on both master and parallel slave).

            Elkin Andrei Elkin added a comment - alice : We need to test this and MDEV-24302 (being committed shortly) patch in stress environment. I'll attach mtr test that attempts that, but it won't be added to the patch as we need some tens of minutes running load (on both master and parallel slave).
            Elkin Andrei Elkin added a comment -

            Attached test is run to pass for over 10 mins. It'd be great to have a RQG-based one and run longer on master and parallel slave, and with actual crash-recovery. alice, we need such test anyway to run periodically, so efforts to that direction now
            are motivated by this bug fixes.

            Elkin Andrei Elkin added a comment - Attached test is run to pass for over 10 mins. It'd be great to have a RQG-based one and run longer on master and parallel slave, and with actual crash-recovery. alice , we need such test anyway to run periodically, so efforts to that direction now are motivated by this bug fixes.
            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment -

            Hello Andrei,

            Thank you for working on this issue. Code changes look good to my knowledge.
            I have made some improvements to the test please have a look.
            The test changes are pushed onto bb-10.2-andrei.

            https://github.com/MariaDB/server/commit/3c5d708eeb56fd656a0b270004a16c8f041802b7

            Thank you.

            sujatha.sivakumar Sujatha Sivakumar (Inactive) added a comment - Hello Andrei, Thank you for working on this issue. Code changes look good to my knowledge. I have made some improvements to the test please have a look. The test changes are pushed onto bb-10.2-andrei. https://github.com/MariaDB/server/commit/3c5d708eeb56fd656a0b270004a16c8f041802b7 Thank you.
            Elkin Andrei Elkin added a comment -

            2a7dd6442 pushed to 10.2.

            Elkin Andrei Elkin added a comment - 2a7dd6442 pushed to 10.2.

            People

              Elkin Andrei Elkin
              Elkin Andrei Elkin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.