Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24124

MariaDB Server sources contain binary blobs, source code missing

Details

    Description

      While importing MariaDB Server 10.5.7 into Debian I noticed in the sources the binary file:

      storage/columnstore/columnstore/utils/jemalloc/libjemalloc.so.2

      This is a big no-no in an open source project for hopefully obvious reasons. Please remove it ASAP.

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MCOL-4554 Fix Jemalloc Dependency Issue

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            otto Otto Kekäläinen added a comment -

            Any progress on this one? Which jemalloc.so is this exactly? What version, what arch?

            This should be pulled in at build-time as a dependency, not stored in git "sources".

            otto Otto Kekäläinen added a comment - Any progress on this one? Which jemalloc.so is this exactly? What version, what arch? This should be pulled in at build-time as a dependency, not stored in git "sources".
            drrtuy Roman added a comment -

            This jemalloc.so is taken from centos7 and used if the jemalloc package is
            absent on centos7 only. JFYI We support only x86_64 ATM.

            drrtuy Roman added a comment - This jemalloc.so is taken from centos7 and used if the jemalloc package is absent on centos7 only. JFYI We support only x86_64 ATM.
            drrtuy Roman added a comment -

            There is no progress on this so far. We will begin with the replacement at
            the end of January.

            drrtuy Roman added a comment - There is no progress on this so far. We will begin with the replacement at the end of January.
            drrtuy Roman added a comment -

            IMHO this shouldn't be neither pulled nor stored but build from jemalloc
            sources.

            drrtuy Roman added a comment - IMHO this shouldn't be neither pulled nor stored but build from jemalloc sources.
            otto Otto Kekäläinen added a comment -

            According to https://pkgs.org/search/?q=jemalloc libjemalloc-dev is available for Centos 7 and you could just use it as a build dependency like any other build dependency.

            otto Otto Kekäläinen added a comment - According to https://pkgs.org/search/?q=jemalloc libjemalloc-dev is available for Centos 7 and you could just use it as a build dependency like any other build dependency.
            drrtuy Roman added a comment -

            It is in the external repo that is why there is a binary in the code.

            drrtuy Roman added a comment - It is in the external repo that is why there is a binary in the code.
            otto Otto Kekäläinen added a comment -

            This was fixed by in https://github.com/mariadb-corporation/mariadb-columnstore-engine/commit/c74beb617858bf4a8f9ae95ad25451cd99764c8a

            otto Otto Kekäläinen added a comment - This was fixed by in https://github.com/mariadb-corporation/mariadb-columnstore-engine/commit/c74beb617858bf4a8f9ae95ad25451cd99764c8a

            People

              gdorman Gregory Dorman (Inactive)
              otto Otto Kekäläinen
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.