Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-24093

Detect during mysql_upgrade if type_mysql_json.so is needed and load it

Details

    Description

      After MDEV-18323, MYSQL_JSON type is available as a dynamically load-able plugin.

      To make mysql_upgrade seamless, we need to make sure it is loaded appropriately. We do not want the plugin to hang around post-upgrade so make sure it is also uninstalled after upgrade is complete.

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-32462 mysql_upgrade -s still checks for non system tables

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-18323 Convert MySQL JSON type to MariaDB TEXT in mysql_upgrade

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            cvicentiu Vicențiu Ciorbaru created issue -
            cvicentiu Vicențiu Ciorbaru made changes -
            Field Original Value New Value
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicențiu Ciorbaru [ cvicentiu ]
            anel Anel Husakovic made changes -
            Assignee Vicențiu Ciorbaru [ cvicentiu ] Anel Husakovic [ anel ]
            anel Anel Husakovic added a comment -

            cvicentiu please review 73b5911bfe3dc2f.

            anel Anel Husakovic added a comment - cvicentiu please review 73b5911bfe3dc2f .
            anel Anel Husakovic made changes -
            Fix Version/s 10.5 [ 23123 ]
            anel Anel Husakovic made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            anel Anel Husakovic made changes -
            Assignee Anel Husakovic [ anel ] Vicențiu Ciorbaru [ cvicentiu ]
            Status Confirmed [ 10101 ] In Review [ 10002 ]
            cvicentiu Vicențiu Ciorbaru made changes -
            Assignee Vicențiu Ciorbaru [ cvicentiu ] Anel Husakovic [ anel ]
            Status In Review [ 10002 ] Stalled [ 10000 ]
            cvicentiu Vicențiu Ciorbaru added a comment -

            OK to push with the changes discussed:

            1. Change commit message to briefly describe logic:
            a. The change makes mariadb-upgrade detect if MYSQL_JSON datatype is needed.
            b. Install the datatype if it's not installed.
            c. Uninstalls the datatype once finished.

            2. What happens when install soname fails?
            The code needs error checking, particularly if the plugin doesn't exist or the server plugin maturity level prevents it from starting.

            cvicentiu Vicențiu Ciorbaru added a comment - OK to push with the changes discussed: 1. Change commit message to briefly describe logic: a. The change makes mariadb-upgrade detect if MYSQL_JSON datatype is needed. b. Install the datatype if it's not installed. c. Uninstalls the datatype once finished. 2. What happens when install soname fails? The code needs error checking, particularly if the plugin doesn't exist or the server plugin maturity level prevents it from starting.
            anel Anel Husakovic added a comment - - edited

            cvicentiu please review 555b11c7f8e222

            anel Anel Husakovic added a comment - - edited cvicentiu please review 555b11c7f8e222
            anel Anel Husakovic made changes -
            Assignee Anel Husakovic [ anel ] Vicențiu Ciorbaru [ cvicentiu ]
            Status Stalled [ 10000 ] In Review [ 10002 ]
            anel Anel Husakovic made changes -
            Assignee Vicențiu Ciorbaru [ cvicentiu ] Anel Husakovic [ anel ]
            anel Anel Husakovic added a comment -

            Pushed to 10.5 with 85130c5a4ff4cc3

            anel Anel Husakovic added a comment - Pushed to 10.5 with 85130c5a4ff4cc3
            anel Anel Husakovic made changes -
            Fix Version/s 10.5.9 [ 25109 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 115193 ] MariaDB v4 [ 134355 ]
            danblack Daniel Black made changes -

            People

              anel Anel Husakovic
              cvicentiu Vicențiu Ciorbaru
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.