[MDEV-24093] Detect during mysql_upgrade if type_mysql_json.so is needed and load it Created: 2020-11-02  Updated: 2023-10-13  Resolved: 2021-01-28

Status: Closed
Project: MariaDB Server
Component/s: Data types, Upgrades
Fix Version/s: 10.5.9

Type: Task Priority: Major
Reporter: Vicențiu Ciorbaru Assignee: Anel Husakovic
Resolution: Fixed Votes: 1
Labels: None

Issue Links:
Problem/Incident
causes MDEV-32462 mysql_upgrade -s still checks for non... Closed
Relates
relates to MDEV-18323 Convert MySQL JSON type to MariaDB TE... Closed

 Description   

After MDEV-18323, MYSQL_JSON type is available as a dynamically load-able plugin.

To make mysql_upgrade seamless, we need to make sure it is loaded appropriately. We do not want the plugin to hang around post-upgrade so make sure it is also uninstalled after upgrade is complete.

 Comments   
Comment by Anel Husakovic [ 2021-01-20 ]

cvicentiu please review 73b5911bfe3dc2f.

Comment by Vicențiu Ciorbaru [ 2021-01-25 ]

OK to push with the changes discussed:

1. Change commit message to briefly describe logic:
a. The change makes mariadb-upgrade detect if MYSQL_JSON datatype is needed.
b. Install the datatype if it's not installed.
c. Uninstalls the datatype once finished.

2. What happens when install soname fails?
The code needs error checking, particularly if the plugin doesn't exist or the server plugin maturity level prevents it from starting.

Comment by Anel Husakovic [ 2021-01-26 ]

cvicentiu please review 555b11c7f8e222

Comment by Anel Husakovic [ 2021-01-28 ]

Pushed to 10.5 with 85130c5a4ff4cc3

Generated at Thu Feb 08 09:27:23 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.