Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23941

mariadb-10.5.6/strings/json_lib.c:913:12: style: Suspicious condition

Details

    Description

      mariadb-10.5.6/strings/json_lib.c:913:12: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
      

      Source code is

        if ((c_len= json_next_char(&j->s) > 0))
      

      Attachments

        Activity

          dcb David Binderman created issue -
          cvicentiu Vicențiu Ciorbaru made changes -
          Field Original Value New Value
          Key MDBF-154 MDEV-23941
          Workflow MFWA: Task Management Workflow [ 114334 ] MariaDB v3 [ 114482 ]
          Project MariaDB Foundation Development [ 11901 ] MariaDB Server [ 10000 ]
          Status To Do [ 10003 ] Open [ 1 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Assignee Vicențiu Ciorbaru [ cvicentiu ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Description mariadb-10.5.6/strings/json_lib.c:913:12: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]

          Source code is

             if ((c_len= json_next_char(&j->s) > 0))
          {code}
          mariadb-10.5.6/strings/json_lib.c:913:12: style: Suspicious condition (assignment + comparison); Clarify expression with parentheses. [clarifyCondition]
          {code}
          Source code is

          {code}
            if ((c_len= json_next_char(&j->s) > 0))
          {code}
          cvicentiu Vicențiu Ciorbaru made changes -
          Priority Major [ 3 ] Trivial [ 5 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Affects Version/s 10.2 [ 14601 ]
          Affects Version/s 10.3 [ 22126 ]
          Affects Version/s 10.4 [ 22408 ]
          Affects Version/s 10.5 [ 23123 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Component/s JSON [ 13908 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          Labels bug
          cvicentiu Vicențiu Ciorbaru made changes -
          Labels bug
          cvicentiu Vicențiu Ciorbaru made changes -
          Status Open [ 1 ] In Progress [ 3 ]

          Thanks for the bug report. A fix will be pushed soon to 10.2.

          cvicentiu Vicențiu Ciorbaru added a comment - Thanks for the bug report. A fix will be pushed soon to 10.2.
          cvicentiu Vicențiu Ciorbaru made changes -
          Fix Version/s 10.2.35 [ 25022 ]
          Fix Version/s 10.3.26 [ 25021 ]
          Fix Version/s 10.4.16 [ 25020 ]
          Fix Version/s 10.5.7 [ 25019 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 114482 ] MariaDB v4 [ 158454 ]

          People

            cvicentiu Vicențiu Ciorbaru
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.