In a 10.5-based branch, we got an assertion failure on the shutdown of mariabackup --prepare:
2020-09-18 6:37:20 0 [Note] InnoDB: Initializing buffer pool, total size = 104857600, chunk size = 104857600
|
2020-09-18 6:37:20 0 [Note] InnoDB: Completed initialization of buffer pool
|
2020-09-18 6:37:21 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
|
2020-09-18 6:37:21 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=3423646
|
2020-09-18 6:37:21 0 [Note] InnoDB: Starting final batch to recover 44 pages from redo log.
|
2020-09-18 6:37:22 0 [Note] InnoDB: Last binlog file './mysql-bin.000001', position 970415
|
[00] 2020-09-18 06:37:23 Last binlog file ./mysql-bin.000001, position 970415
|
2020-09-18 06:37:23 0x2bf14d750800 InnoDB: Assertion failure in file /home/mleich/Server/bb-10.5-MDEV-23399B/storage/innobase/fil/fil0fil.cc line 508
|
InnoDB: Failing assertion: n_pending_flushes == 0
|
I believe that this failure is possible also during server shutdown.
The fix should be to check for pending flushes while closing files:
diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc
|
index f549938bfc2..84425e0d1b6 100644
|
--- a/storage/innobase/fil/fil0fil.cc
|
+++ b/storage/innobase/fil/fil0fil.cc
|
@@ -1601,7 +1601,8 @@ void fil_close_all_files()
|
if (!node->is_open()) {
|
goto next;
|
}
|
- if (!node->n_pending) {
|
+ if (!node->n_pending
|
+ && !node->n_pending_flushes) {
|
node->close();
|
goto next;
|
}
|
@@ -1609,7 +1610,9 @@ void fil_close_all_files()
|
|
ib::error() << "File '" << node->name
|
<< "' has " << node->n_pending
|
- << " operations";
|
+ << " operations and "
|
+ << node->n_pending_flushes
|
+ << " flushes";
|
}
|
|
space = UT_LIST_GET_NEXT(space_list, space);
|
- is caused by
-
MDEV-15053
Reduce buf_pool_t::mutex contention
-
-
Closed
{"report":{"fcp":998,"ttfb":253.20000000298023,"pageVisibility":"visible","entityId":91998,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"65bcd4ec-061a-45df-82e2-9b41ab8c615b","navigationType":0,"readyForUser":1096,"redirectCount":0,"resourceLoadedEnd":1082.4000000059605,"resourceLoadedStart":258.70000000298023,"resourceTiming":[{"duration":137.70000000298023,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":258.70000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":258.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":396.40000000596046,"responseStart":0,"secureConnectionStart":0},{"duration":137.70000000298023,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":259,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":259,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":396.70000000298023,"responseStart":0,"secureConnectionStart":0},{"duration":180.79999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":259.1000000089407,"connectEnd":259.1000000089407,"connectStart":259.1000000089407,"domainLookupEnd":259.1000000089407,"domainLookupStart":259.1000000089407,"fetchStart":259.1000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":259.1000000089407,"responseEnd":439.90000000596046,"responseStart":439.90000000596046,"secureConnectionStart":259.1000000089407},{"duration":256.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":259.40000000596046,"connectEnd":259.40000000596046,"connectStart":259.40000000596046,"domainLookupEnd":259.40000000596046,"domainLookupStart":259.40000000596046,"fetchStart":259.40000000596046,"redirectEnd":0,"redirectStart":0,"requestStart":259.40000000596046,"responseEnd":515.9000000059605,"responseStart":515.9000000059605,"secureConnectionStart":259.40000000596046},{"duration":259.79999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":259.6000000089407,"connectEnd":259.6000000089407,"connectStart":259.6000000089407,"domainLookupEnd":259.6000000089407,"domainLookupStart":259.6000000089407,"fetchStart":259.6000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":259.6000000089407,"responseEnd":519.4000000059605,"responseStart":519.4000000059605,"secureConnectionStart":259.6000000089407},{"duration":260.1000000089407,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":259.70000000298023,"connectEnd":259.70000000298023,"connectStart":259.70000000298023,"domainLookupEnd":259.70000000298023,"domainLookupStart":259.70000000298023,"fetchStart":259.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":259.70000000298023,"responseEnd":519.8000000119209,"responseStart":519.8000000119209,"secureConnectionStart":259.70000000298023},{"duration":260.30000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":260,"connectEnd":260,"connectStart":260,"domainLookupEnd":260,"domainLookupStart":260,"fetchStart":260,"redirectEnd":0,"redirectStart":0,"requestStart":260,"responseEnd":520.3000000119209,"responseStart":520.3000000119209,"secureConnectionStart":260},{"duration":323.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":260.20000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":260.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":584.1000000089407,"responseStart":0,"secureConnectionStart":0},{"duration":260.3999999910593,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":260.30000001192093,"connectEnd":260.30000001192093,"connectStart":260.30000001192093,"domainLookupEnd":260.30000001192093,"domainLookupStart":260.30000001192093,"fetchStart":260.30000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":260.30000001192093,"responseEnd":520.7000000029802,"responseStart":520.7000000029802,"secureConnectionStart":260.30000001192093},{"duration":323.70000000298023,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":260.70000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":260.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":584.4000000059605,"responseStart":0,"secureConnectionStart":0},{"duration":260.3999999910593,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":260.80000001192093,"connectEnd":260.80000001192093,"connectStart":260.80000001192093,"domainLookupEnd":260.80000001192093,"domainLookupStart":260.80000001192093,"fetchStart":260.80000001192093,"redirectEnd":0,"redirectStart":0,"requestStart":260.80000001192093,"responseEnd":521.2000000029802,"responseStart":521.2000000029802,"secureConnectionStart":260.80000001192093},{"duration":508.29999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":271.1000000089407,"connectEnd":271.1000000089407,"connectStart":271.1000000089407,"domainLookupEnd":271.1000000089407,"domainLookupStart":271.1000000089407,"fetchStart":271.1000000089407,"redirectEnd":0,"redirectStart":0,"requestStart":271.1000000089407,"responseEnd":779.4000000059605,"responseStart":779.4000000059605,"secureConnectionStart":271.1000000089407},{"duration":811.2000000029802,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":271.20000000298023,"connectEnd":271.20000000298023,"connectStart":271.20000000298023,"domainLookupEnd":271.20000000298023,"domainLookupStart":271.20000000298023,"fetchStart":271.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":271.20000000298023,"responseEnd":1082.4000000059605,"responseStart":1082.4000000059605,"secureConnectionStart":271.20000000298023},{"duration":183.40000000596046,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":596.2000000029802,"connectEnd":596.2000000029802,"connectStart":596.2000000029802,"domainLookupEnd":596.2000000029802,"domainLookupStart":596.2000000029802,"fetchStart":596.2000000029802,"redirectEnd":0,"redirectStart":0,"requestStart":596.2000000029802,"responseEnd":779.6000000089407,"responseStart":779.6000000089407,"secureConnectionStart":596.2000000029802},{"duration":328.29999999701977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":885.2000000029802,"connectEnd":885.2000000029802,"connectStart":885.2000000029802,"domainLookupEnd":885.2000000029802,"domainLookupStart":885.2000000029802,"fetchStart":885.2000000029802,"redirectEnd":0,"redirectStart":0,"requestStart":885.2000000029802,"responseEnd":1213.5,"responseStart":1213.5,"secureConnectionStart":885.2000000029802}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":90,"responseStart":253,"responseEnd":259,"domLoading":257,"domInteractive":1171,"domContentLoadedEventStart":1171,"domContentLoadedEventEnd":1243,"domComplete":2680,"loadEventStart":2680,"loadEventEnd":2681,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1147.800000011921},{"name":"bigPipe.sidebar-id.end","time":1148.6000000089407},{"name":"bigPipe.activity-panel-pipe-id.start","time":1148.7000000029802},{"name":"bigPipe.activity-panel-pipe-id.end","time":1156.300000011921},{"name":"activityTabFullyLoaded","time":1255.6000000089407}],"measures":[],"correlationId":"7e1e376861fde7","effectiveType":"4g","downlink":9.2,"rtt":0,"serverDuration":98,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}