In a 10.5-based branch, we got an assertion failure on the shutdown of mariabackup --prepare:
2020-09-18 6:37:20 0 [Note] InnoDB: Initializing buffer pool, total size = 104857600, chunk size = 104857600
|
2020-09-18 6:37:20 0 [Note] InnoDB: Completed initialization of buffer pool
|
2020-09-18 6:37:21 0 [Note] InnoDB: If the mysqld execution user is authorized, page cleaner thread priority can be changed. See the man page of setpriority().
|
2020-09-18 6:37:21 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=3423646
|
2020-09-18 6:37:21 0 [Note] InnoDB: Starting final batch to recover 44 pages from redo log.
|
2020-09-18 6:37:22 0 [Note] InnoDB: Last binlog file './mysql-bin.000001', position 970415
|
[00] 2020-09-18 06:37:23 Last binlog file ./mysql-bin.000001, position 970415
|
2020-09-18 06:37:23 0x2bf14d750800 InnoDB: Assertion failure in file /home/mleich/Server/bb-10.5-MDEV-23399B/storage/innobase/fil/fil0fil.cc line 508
|
InnoDB: Failing assertion: n_pending_flushes == 0
|
I believe that this failure is possible also during server shutdown.
The fix should be to check for pending flushes while closing files:
diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc
|
index f549938bfc2..84425e0d1b6 100644
|
--- a/storage/innobase/fil/fil0fil.cc
|
+++ b/storage/innobase/fil/fil0fil.cc
|
@@ -1601,7 +1601,8 @@ void fil_close_all_files()
|
if (!node->is_open()) {
|
goto next;
|
}
|
- if (!node->n_pending) {
|
+ if (!node->n_pending
|
+ && !node->n_pending_flushes) {
|
node->close();
|
goto next;
|
}
|
@@ -1609,7 +1610,9 @@ void fil_close_all_files()
|
|
ib::error() << "File '" << node->name
|
<< "' has " << node->n_pending
|
- << " operations";
|
+ << " operations and "
|
+ << node->n_pending_flushes
|
+ << " flushes";
|
}
|
|
space = UT_LIST_GET_NEXT(space_list, space);
|
- is caused by
-
MDEV-15053
Reduce buf_pool_t::mutex contention
-
-
Closed
{"report":{"fcp":1514,"ttfb":428.2000000476837,"pageVisibility":"visible","entityId":91998,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"cbfd3581-07b3-415d-bc6e-e7035e9885aa","navigationType":0,"readyForUser":1634,"redirectCount":0,"resourceLoadedEnd":1704.7000000476837,"resourceLoadedStart":434.59999990463257,"resourceTiming":[{"duration":463.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":434.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":434.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":898.5,"responseStart":0,"secureConnectionStart":0},{"duration":464.2000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":434.7999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":434.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":899,"responseStart":0,"secureConnectionStart":0},{"duration":563.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":435,"connectEnd":435,"connectStart":435,"domainLookupEnd":435,"domainLookupStart":435,"fetchStart":435,"redirectEnd":0,"redirectStart":0,"requestStart":435,"responseEnd":998.7999999523163,"responseStart":998.7999999523163,"secureConnectionStart":435},{"duration":695.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":435.2999999523163,"connectEnd":435.2999999523163,"connectStart":435.2999999523163,"domainLookupEnd":435.2999999523163,"domainLookupStart":435.2999999523163,"fetchStart":435.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":435.2999999523163,"responseEnd":1131.0999999046326,"responseStart":1131.0999999046326,"secureConnectionStart":435.2999999523163},{"duration":702,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":435.5,"connectEnd":435.5,"connectStart":435.5,"domainLookupEnd":435.5,"domainLookupStart":435.5,"fetchStart":435.5,"redirectEnd":0,"redirectStart":0,"requestStart":435.5,"responseEnd":1137.5,"responseStart":1137.5,"secureConnectionStart":435.5},{"duration":703.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":435.59999990463257,"connectEnd":435.59999990463257,"connectStart":435.59999990463257,"domainLookupEnd":435.59999990463257,"domainLookupStart":435.59999990463257,"fetchStart":435.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":435.59999990463257,"responseEnd":1139,"responseStart":1139,"secureConnectionStart":435.59999990463257},{"duration":705.6000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":435.7999999523163,"connectEnd":435.7999999523163,"connectStart":435.7999999523163,"domainLookupEnd":435.7999999523163,"domainLookupStart":435.7999999523163,"fetchStart":435.7999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":435.7999999523163,"responseEnd":1141.4000000953674,"responseStart":1141.4000000953674,"secureConnectionStart":435.7999999523163},{"duration":732.1000001430511,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":436.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":436.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1168.2000000476837,"responseStart":0,"secureConnectionStart":0},{"duration":705.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":436.2999999523163,"connectEnd":436.2999999523163,"connectStart":436.2999999523163,"domainLookupEnd":436.2999999523163,"domainLookupStart":436.2999999523163,"fetchStart":436.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":436.2999999523163,"responseEnd":1142,"responseStart":1142,"secureConnectionStart":436.2999999523163},{"duration":732.1999998092651,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":436.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":436.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1168.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":715.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":436.5,"connectEnd":436.5,"connectStart":436.5,"domainLookupEnd":436.5,"domainLookupStart":436.5,"fetchStart":436.5,"redirectEnd":0,"redirectStart":0,"requestStart":436.5,"responseEnd":1151.7000000476837,"responseStart":1151.7000000476837,"secureConnectionStart":436.5},{"duration":1022.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":442.2000000476837,"connectEnd":442.2000000476837,"connectStart":442.2000000476837,"domainLookupEnd":442.2000000476837,"domainLookupStart":442.2000000476837,"fetchStart":442.2000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":442.2000000476837,"responseEnd":1464.7000000476837,"responseStart":1464.7000000476837,"secureConnectionStart":442.2000000476837},{"duration":1262.4000000953674,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":442.2999999523163,"connectEnd":442.2999999523163,"connectStart":442.2999999523163,"domainLookupEnd":442.2999999523163,"domainLookupStart":442.2999999523163,"fetchStart":442.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":442.2999999523163,"responseEnd":1704.7000000476837,"responseStart":1704.7000000476837,"secureConnectionStart":442.2999999523163},{"duration":266.7999999523163,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1201.2999999523163,"connectEnd":1201.2999999523163,"connectStart":1201.2999999523163,"domainLookupEnd":1201.2999999523163,"domainLookupStart":1201.2999999523163,"fetchStart":1201.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":1201.2999999523163,"responseEnd":1468.0999999046326,"responseStart":1468.0999999046326,"secureConnectionStart":1201.2999999523163}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":274,"responseStart":428,"responseEnd":441,"domLoading":432,"domInteractive":1777,"domContentLoadedEventStart":1778,"domContentLoadedEventEnd":1846,"domComplete":2946,"loadEventStart":2946,"loadEventEnd":2948,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1755.2000000476837},{"name":"bigPipe.sidebar-id.end","time":1756.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.start","time":1757.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":1759.5999999046326},{"name":"activityTabFullyLoaded","time":1853.7000000476837}],"measures":[],"correlationId":"464617a254a645","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":92,"dbReadsTimeInMs":11,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}