Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23777

mtr --rr leaves a broken trace in some cases

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open (View Workflow)
    • Priority: Major
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      We have a working patch that fixes a problem:

       Index: mysql-test/lib/My/SafeProcess/safe_process.cc
       IDEA additional info:
       Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
       <+>UTF-8
       ===================================================================
       --- mysql-test/lib/My/SafeProcess/safe_process.cc    (revision a7e7508a75f6bd87ac8e8d1f32930e1f3799d226)
       +++ mysql-test/lib/My/SafeProcess/safe_process.cc    (date 1596518504000)
       @@ -97,7 +97,7 @@
          message("Killing child: %d", child_pid);
          // Terminate whole process group
          if (! was_killed)
       -    kill(-child_pid, SIGKILL);
       +    kill(-child_pid, SIGINT);
        
          pid_t ret_pid= waitpid(child_pid, &status, 0);
          if (ret_pid == child_pid)
      

      However it needs a hang defence to be in trunk.

      Marko: IMO that one should be replaced with something like SIGINT, wait a bit, SIGABRT (to get proof of server shutdown hang), wait a bit more, then SIGKILL

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              midenok Aleksey Midenkov
              Reporter:
              nikitamalyavin Nikita Malyavin
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:

                  Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.