When MDEV-22669 introduced CRC-32C acceleration to IA-32, it worked around a bug of GCC 4 by disabling the acceleration for IA-32. The bug only affects the generating of position independent code (-fPIC):
/home/buildbot/buildbot/build/storage/innobase/ut/ut0crc32.cc: In function 'void ut_crc32_init()':
|
/home/buildbot/buildbot/build/storage/innobase/ut/ut0crc32.cc:120:50: error: PIC register clobbered by 'ebx' in 'asm'
|
asm("cpuid" : "=c"(i) : "ax"(1) : "ebx", "edx");
|
In MDEV-23585 I found a more elegant solution to this problem: implement a CMake check for that the cpuid instruction.
We can extend this check so that the source code can simply refer to HAVE_CPUID_INSTRUCTION. In that way, only those platforms that are affected by the compiler bug will avoid using any instruction set extensions.
Clarification: We always generated the CPUID instruction for AMD64. We only unnecessarily disabled it on IA-32 in some cases. I do not know whether and how the code could be compiled without -fPIC.
- is caused by
-
MDEV-22669
InnoDB lacks CRC-32C acceleration on IA-32
-
-
Closed
{"report":{"fcp":1090,"ttfb":403.79999923706055,"pageVisibility":"visible","entityId":91244,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"cdbe1469-a39e-4ffc-84be-ef4d3b58e677","navigationType":0,"readyForUser":1160.5,"redirectCount":0,"resourceLoadedEnd":1122.0999994277954,"resourceLoadedStart":409.19999980926514,"resourceTiming":[{"duration":148.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":409.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":409.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":557.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":148.79999923706055,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":409.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":409.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":558.2999992370605,"responseStart":0,"secureConnectionStart":0},{"duration":209,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":409.5999994277954,"connectEnd":409.5999994277954,"connectStart":409.5999994277954,"domainLookupEnd":409.5999994277954,"domainLookupStart":409.5999994277954,"fetchStart":409.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":409.5999994277954,"responseEnd":618.5999994277954,"responseStart":618.5999994277954,"secureConnectionStart":409.5999994277954},{"duration":282.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":409.69999980926514,"connectEnd":409.69999980926514,"connectStart":409.69999980926514,"domainLookupEnd":409.69999980926514,"domainLookupStart":409.69999980926514,"fetchStart":409.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":409.69999980926514,"responseEnd":692.5,"responseStart":692.5,"secureConnectionStart":409.69999980926514},{"duration":286.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":410,"connectEnd":410,"connectStart":410,"domainLookupEnd":410,"domainLookupStart":410,"fetchStart":410,"redirectEnd":0,"redirectStart":0,"requestStart":410,"responseEnd":696.3999996185303,"responseStart":696.3999996185303,"secureConnectionStart":410},{"duration":286.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":410.0999994277954,"connectEnd":410.0999994277954,"connectStart":410.0999994277954,"domainLookupEnd":410.0999994277954,"domainLookupStart":410.0999994277954,"fetchStart":410.0999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":410.0999994277954,"responseEnd":696.7999992370605,"responseStart":696.7999992370605,"secureConnectionStart":410.0999994277954},{"duration":286.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":410.3999996185303,"connectEnd":410.3999996185303,"connectStart":410.3999996185303,"domainLookupEnd":410.3999996185303,"domainLookupStart":410.3999996185303,"fetchStart":410.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":410.3999996185303,"responseEnd":697.1999998092651,"responseStart":697.1999998092651,"secureConnectionStart":410.3999996185303},{"duration":350.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":410.5999994277954,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":410.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":760.8999996185303,"responseStart":0,"secureConnectionStart":0},{"duration":287.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":410.5999994277954,"connectEnd":410.5999994277954,"connectStart":410.5999994277954,"domainLookupEnd":410.5999994277954,"domainLookupStart":410.5999994277954,"fetchStart":410.5999994277954,"redirectEnd":0,"redirectStart":0,"requestStart":410.5999994277954,"responseEnd":697.6999998092651,"responseStart":697.5999994277954,"secureConnectionStart":410.5999994277954},{"duration":350.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":410.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":410.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":761.0999994277954,"responseStart":0,"secureConnectionStart":0},{"duration":287.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":410.8999996185303,"connectEnd":410.8999996185303,"connectStart":410.8999996185303,"domainLookupEnd":410.8999996185303,"domainLookupStart":410.8999996185303,"fetchStart":410.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":410.8999996185303,"responseEnd":698.1999998092651,"responseStart":698.1999998092651,"secureConnectionStart":410.8999996185303},{"duration":537.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":411.79999923706055,"connectEnd":411.79999923706055,"connectStart":411.79999923706055,"domainLookupEnd":411.79999923706055,"domainLookupStart":411.79999923706055,"fetchStart":411.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":411.79999923706055,"responseEnd":949.5999994277954,"responseStart":949.5999994277954,"secureConnectionStart":411.79999923706055},{"duration":687.8000001907349,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":411.79999923706055,"connectEnd":411.79999923706055,"connectStart":411.79999923706055,"domainLookupEnd":411.79999923706055,"domainLookupStart":411.79999923706055,"fetchStart":411.79999923706055,"redirectEnd":0,"redirectStart":0,"requestStart":411.79999923706055,"responseEnd":1099.5999994277954,"responseStart":1099.5999994277954,"secureConnectionStart":411.79999923706055},{"duration":202.30000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":772.1999998092651,"connectEnd":772.1999998092651,"connectStart":772.1999998092651,"domainLookupEnd":772.1999998092651,"domainLookupStart":772.1999998092651,"fetchStart":772.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":772.1999998092651,"responseEnd":974.5,"responseStart":974.5,"secureConnectionStart":772.1999998092651},{"duration":70.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1030.6999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1030.6999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1101.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":86.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1031.5,"connectEnd":1031.5,"connectStart":1031.5,"domainLookupEnd":1031.5,"domainLookupStart":1031.5,"fetchStart":1031.5,"redirectEnd":0,"redirectStart":0,"requestStart":1031.5,"responseEnd":1117.6999998092651,"responseStart":1117.6999998092651,"secureConnectionStart":1031.5},{"duration":90.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1031.8999996185303,"connectEnd":1031.8999996185303,"connectStart":1031.8999996185303,"domainLookupEnd":1031.8999996185303,"domainLookupStart":1031.8999996185303,"fetchStart":1031.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":1031.8999996185303,"responseEnd":1122.0999994277954,"responseStart":1122.0999994277954,"secureConnectionStart":1031.8999996185303},{"duration":149.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1084,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1084,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1233.5,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":241,"responseStart":403,"responseEnd":406,"domLoading":407,"domInteractive":1254,"domContentLoadedEventStart":1254,"domContentLoadedEventEnd":1290,"domComplete":1871,"loadEventStart":1871,"loadEventEnd":1873,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1234.7999992370605},{"name":"bigPipe.sidebar-id.end","time":1235.7999992370605},{"name":"bigPipe.activity-panel-pipe-id.start","time":1236},{"name":"bigPipe.activity-panel-pipe-id.end","time":1238.3999996185303},{"name":"activityTabFullyLoaded","time":1302.8999996185303}],"measures":[],"correlationId":"8bc7f33285768f","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":102,"dbReadsTimeInMs":14,"dbConnsTimeInMs":23,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}