Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23358

main.upgrade_MDEV-19650 fails with result difference

Details

    Description

      The test main.upgrade_MDEV-19560 fails with a result difference after a merge from 10.3 66ec3a770f7854f500ece66c78f3c87c9cd6da15:

      CURRENT_TEST: main.upgrade_MDEV-19650
      --- /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.result	2020-07-31 14:24:17.304978248 +0300
      +++ /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.reject	2020-07-31 17:25:27.973255284 +0300
      @@ -165,6 +165,7 @@
       SELECT * FROM information_schema.TABLE_PRIVILEGES WHERE GRANTEE="'mariadb.sys'@'localhost'";
       GRANTEE	TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PRIVILEGE_TYPE	IS_GRANTABLE
       'mariadb.sys'@'localhost'	def	mysql	global_priv	SELECT	NO
      +'mariadb.sys'@'localhost'	def	mysql	global_priv	UPDATE	NO
       'mariadb.sys'@'localhost'	def	mysql	global_priv	DELETE	NO
       # check non root
       CREATE USER 'not_root'@'localhost';
       
      mysqltest: Result length mismatch
      

      Attachments

        Activity

          I temporarily disabled the test because it apparently passes in some environments. I tested a debug build on both clang 10.0.1 and GCC 10.1.0.

          marko Marko Mäkelä added a comment - I temporarily disabled the test because it apparently passes in some environments. I tested a debug build on both clang 10.0.1 and GCC 10.1.0.

          I did not disable the test on a merge to 10.5, because for some reason, the test did not fail for me.

          marko Marko Mäkelä added a comment - I did not disable the test on a merge to 10.5 , because for some reason, the test did not fail for me.

          serg, yes, the still fails for me on 10.4 after merging mariadb-10.4.14:

          CURRENT_TEST: main.upgrade_MDEV-19650
          --- /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.result	2020-08-04 11:20:39.773055621 +0300
          +++ /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.reject	2020-08-10 20:49:11.150731966 +0300
          @@ -165,6 +165,7 @@
           SELECT * FROM information_schema.TABLE_PRIVILEGES WHERE GRANTEE="'mariadb.sys'@'localhost'";
           GRANTEE	TABLE_CATALOG	TABLE_SCHEMA	TABLE_NAME	PRIVILEGE_TYPE	IS_GRANTABLE
           'mariadb.sys'@'localhost'	def	mysql	global_priv	SELECT	NO
          +'mariadb.sys'@'localhost'	def	mysql	global_priv	UPDATE	NO
           'mariadb.sys'@'localhost'	def	mysql	global_priv	DELETE	NO
           # check non root
           CREATE USER 'not_root'@'localhost';
           
          mysqltest: Result length mismatch
          

          Curiously, it never failed for me on 10.5 or 10.6 (and hence I had disabled the test only in the 10.4 branch).

          I am happy to help debug this, but I would need some directions from you.

          marko Marko Mäkelä added a comment - serg , yes, the still fails for me on 10.4 after merging mariadb-10.4.14: CURRENT_TEST: main.upgrade_MDEV-19650 --- /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.result 2020-08-04 11:20:39.773055621 +0300 +++ /mariadb/10.4/mysql-test/main/upgrade_MDEV-19650.reject 2020-08-10 20:49:11.150731966 +0300 @@ -165,6 +165,7 @@ SELECT * FROM information_schema.TABLE_PRIVILEGES WHERE GRANTEE="'mariadb.sys'@'localhost'"; GRANTEE TABLE_CATALOG TABLE_SCHEMA TABLE_NAME PRIVILEGE_TYPE IS_GRANTABLE 'mariadb.sys'@'localhost' def mysql global_priv SELECT NO +'mariadb.sys'@'localhost' def mysql global_priv UPDATE NO 'mariadb.sys'@'localhost' def mysql global_priv DELETE NO # check non root CREATE USER 'not_root'@'localhost';   mysqltest: Result length mismatch Curiously, it never failed for me on 10.5 or 10.6 (and hence I had disabled the test only in the 10.4 branch). I am happy to help debug this, but I would need some directions from you.

          This still fails for me in 10.4 2fa9f8c53a80e8b52c14d8c3260b18e7e77cc154.

          marko Marko Mäkelä added a comment - This still fails for me in 10.4 2fa9f8c53a80e8b52c14d8c3260b18e7e77cc154.

          marko, I cannot repeat it, it doesn't happen in buildbot. Could you please show how I can reproduce the failure?

          serg Sergei Golubchik added a comment - marko , I cannot repeat it, it doesn't happen in buildbot. Could you please show how I can reproduce the failure?

          This still fails for me on 10.4 1e08e08ccb8896c1f0d2f673c16f5b92cdf7dc46 (and not on any 10.5).

          marko Marko Mäkelä added a comment - This still fails for me on 10.4 1e08e08ccb8896c1f0d2f673c16f5b92cdf7dc46 (and not on any 10.5).

          It turns out that I had accidentally invoked an in-tree build on my 10.4 directory in the past. There was a stale copy of the generated file scripts/mysql_fix_privilege_tables_sql.c in the source directory. That file was incorrectly used during the out-of-source build of the executable. I finally found that out by invoking strace on the compilation command. (First, I had replaced the -c and -o options of that command with -E -dD to find out that the unexpected UPDATE privilege was part of an INSERT statement.)

          marko Marko Mäkelä added a comment - It turns out that I had accidentally invoked an in-tree build on my 10.4 directory in the past. There was a stale copy of the generated file scripts/mysql_fix_privilege_tables_sql.c in the source directory. That file was incorrectly used during the out-of-source build of the executable. I finally found that out by invoking strace on the compilation command. (First, I had replaced the -c and -o options of that command with -E -dD to find out that the unexpected UPDATE privilege was part of an INSERT statement.)

          People

            serg Sergei Golubchik
            marko Marko Mäkelä
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.