Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-23027

symlink_wsrep_sst_rsync target built when WITH_WSREP is off

Details

    Description

      I am configuring with numerous options including -DWITH_WSREP=OFF -DPLUGIN_WSREP_INFO=NO. But, after cmake generates the build framework, I see the following as the last item in a build:

      Scanning dependencies of target symlink_wsrep_sst_rsync
      [100%] Generating wsrep_sst_rsync_wan
      [100%] Built target symlink_wsrep_sst_rsync
      

      Additionally, after this, looking in scripts shows:

      % ls -l scripts
      ...
      -rwxr-xr-x  1 cross2 5011   62527 Jun 26 12:28 mytop
      -rw-r--r--  1 cross2 5011   62527 May  9 15:28 mytop.sh
      -rw-r--r--  1 cross2 5011   10688 May  9 15:28 wsrep_sst_common.sh
      -rw-r--r--  1 cross2 5011   37509 May  9 15:28 wsrep_sst_mariabackup.sh
      -rw-r--r--  1 cross2 5011    8020 May  9 15:28 wsrep_sst_mysqldump.sh
      -rw-r--r--  1 cross2 5011   17062 May  9 15:28 wsrep_sst_rsync.sh
      lrwxrwxrwx  1 cross2 5011      15 Jun 26 13:28 wsrep_sst_rsync_wan -> wsrep_sst_rsync
      

      I think this shouldn't be built at all, and I think it's doing something wrong. (symlink to non-existent file)

      Why is there a block related to wsrep_sst_rsync_wan/symlink_wsrep_sst_rsync starting at line 336 in scripts/CMakeLists.txt, but the majority of the WSREP scripts are back at line 276 protected inside of a

      IF(WITH_WSREP)

      ?

      Attachments

        Activity

          cross Chris Ross created issue -
          cvicentiu Vicențiu Ciorbaru made changes -
          Field Original Value New Value
          Assignee Vicențiu Ciorbaru [ cvicentiu ]
          cross Chris Ross made changes -
          Attachment mariadb_MDEV-23027.patch-10.4.13 [ 52745 ]
          Attachment mariadb_MDEV-23027.patch-10.5.4 [ 52746 ]
          cvicentiu Vicențiu Ciorbaru made changes -
          issue.field.resolutiondate 2020-07-13 17:43:29.0 2020-07-13 17:43:29.851
          cvicentiu Vicențiu Ciorbaru made changes -
          Component/s Configuration [ 13904 ]
          Component/s Galera [ 10124 ]
          Component/s Scripts & Clients [ 11002 ]
          Fix Version/s 10.1.46 [ 24308 ]
          Fix Version/s 10.2.33 [ 24307 ]
          Fix Version/s 10.3.24 [ 24306 ]
          Fix Version/s 10.4.14 [ 24305 ]
          Fix Version/s 10.5.5 [ 24423 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 110555 ] MariaDB v4 [ 158027 ]

          People

            cvicentiu Vicențiu Ciorbaru
            cross Chris Ross
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.