Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22931

mtr_t::mtr_t() allocates some memory

Details

    Description

      This was a rather surprising find while profiling.
      mtr_t::mtr_t allocates memory through construction of one of its members

      This allocations accounts for 0.68% of CPU time (constructor itself for 0.77% of CPU time), this happens to be the largest contributor to the "operator new" on oltp_update_index benchmark with bufferpool larger than size of the data ( without doublewrite)

      Attachments

        Issue Links

          Activity

            wlad Vladislav Vaintroub created issue -
            wlad Vladislav Vaintroub made changes -
            Field Original Value New Value
            Assignee Vladislav Vaintroub [ wlad ] Marko Mäkelä [ marko ]
            wlad Vladislav Vaintroub made changes -
            Attachment 2020-06-18 (5).png [ 52249 ]
            wlad Vladislav Vaintroub made changes -
            Description This was a rather surprising find while profiling.
            mtr_t::mtr_t allocates memory through construction of one of its members

            This accounts for 0.68% of CPU time, and happens to be the largest contributor to the "operator new" on oltp_update_index benchmark with bufferpool larger than size of the data.
            This was a rather surprising find while profiling.
            mtr_t::mtr_t allocates memory through construction of one of its members

            This allocations accounts for 0.68% of CPU time (constructor itself for 0.77% of CPU time), this happens to be the largest contributor to the "operator new" on oltp_update_index benchmark with bufferpool larger than size of the data ( without doublewrite)
            wlad Vladislav Vaintroub made changes -
            Attachment 2020-06-18 (6).png [ 52250 ]
            marko Marko Mäkelä made changes -
            Fix Version/s 10.5 [ 23123 ]
            Assignee Marko Mäkelä [ marko ] Eugene Kosov [ kevg ]
            Labels performance
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Labels performance performance regression
            marko Marko Mäkelä made changes -
            Assignee Eugene Kosov [ kevg ] Thirunarayanan Balathandayuthapani [ thiru ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            thiru Thirunarayanan Balathandayuthapani made changes -
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Fix Version/s 10.5.5 [ 24423 ]
            Fix Version/s 10.5.4 [ 24264 ]
            marko Marko Mäkelä made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 110190 ] MariaDB v4 [ 157981 ]

            People

              thiru Thirunarayanan Balathandayuthapani
              wlad Vladislav Vaintroub
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.