Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22930

Unnecessary contention on rw_lock_list_mutex in ibuf_dummy_index_create()

    XMLWordPrintable

Details

    Description

      The function ibuf_dummy_index_create() is creating dummy dict_index_t objects for applying buffered changes. The rw_lock_create() call in this function should be totally unnecessary, because there should be no need to access dict_index_t::lock in those dummy objects at all. We should avoid registering the dummy objects in any global lists.

      When MDEV-11634 implements a more compact change buffer format, that entire code should be removed, or only kept for the purpose of upgrading.

      Attachments

        1. 2020-06-18 (2).png
          585 kB
          Vladislav Vaintroub
        2. 2020-06-18 (4).png
          567 kB
          Vladislav Vaintroub

        Issue Links

          Activity

            People

              kevg Eugene Kosov (Inactive)
              marko Marko Mäkelä
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.