Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Fixed
    • 10.5
    • 10.5.4
    • Compiling
    • None

    Description

          68>D:\win32-debug\build\src\storage\innobase\include\sync0types.h(611,1): error C2220:  warning treated as error - no 'object' file generated (compiling source file D:\win32-debug\build\src\storage\innobase\btr\btr0btr.cc) [D:\win32-debug\build\storage\innobase\innobase.vcxproj]
          68>D:\win32-debug\build\src\storage\innobase\include\sync0types.h(611,1): warning C4307:  '*': integral constant overflow (compiling source file D:\win32-debug\build\src\storage\innobase\btr\btr0btr.cc) [D:\win32-debug\build\storage\innobase\innobase.vcxproj]
      

      Attachments

        Issue Links

          Activity

            serg Sergei Golubchik created issue -
            julien.fritsch Julien Fritsch made changes -
            Field Original Value New Value
            Component/s Compiling [ 11001 ]

            I believe that this was broken by MDEV-22841. I notified the author wlad yesterday, and before leaving for vacation today, he made the 32-bit non-debug build pass.

            I am reassigning this to kevg, because he reviewed MDEV-22841 and because the author is on vacation. The problem should be that uint is too small on 32-bit systems.

            marko Marko Mäkelä added a comment - I believe that this was broken by MDEV-22841 . I notified the author wlad yesterday, and before leaving for vacation today, he made the 32-bit non-debug build pass. I am reassigning this to kevg , because he reviewed MDEV-22841 and because the author is on vacation. The problem should be that uint is too small on 32-bit systems.
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Affects Version/s 10.5 [ 23123 ]
            Assignee Marko Mäkelä [ marko ] Eugene Kosov [ kevg ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Assignee Eugene Kosov [ kevg ] Marko Mäkelä [ marko ]
            marko Marko Mäkelä made changes -
            marko Marko Mäkelä made changes -
            Comment [ I suspect that fixing MDEV-22863 would fix this one as well. ]
            marko Marko Mäkelä made changes -
            Status Open [ 1 ] In Progress [ 3 ]

            Apparently the problem was that some versions of Microsoft Visual Studio would claim that 33 * h overflows uint32_t in the constexpr function evaluation when compiling a 32-bit executable. My fix of uint64_t{33} * h seems to have worked.

            marko Marko Mäkelä added a comment - Apparently the problem was that some versions of Microsoft Visual Studio would claim that 33 * h overflows uint32_t in the constexpr function evaluation when compiling a 32-bit executable. My fix of uint64_t{33} * h seems to have worked.
            marko Marko Mäkelä made changes -
            issue.field.resolutiondate 2020-06-11 12:58:16.0 2020-06-11 12:58:16.232
            marko Marko Mäkelä made changes -
            Fix Version/s 10.5.4 [ 24264 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status In Progress [ 3 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 109883 ] MariaDB v4 [ 157942 ]

            People

              marko Marko Mäkelä
              serg Sergei Golubchik
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.