-
Task
-
-
Major
-
Resolution:
Fixed
-
-
-
Replace the slow loop in my_hash_sort_utf8mbX() to the fast skip_trailing_spaces(), which consumes 8 bytes in one iteration, as follows:
diff --git a/strings/ctype-utf8.c b/strings/ctype-utf8.c
|
index b8e71b1f7a9..7434f968383 100644
|
--- a/strings/ctype-utf8.c
|
+++ b/strings/ctype-utf8.c
|
@@ -4992,13 +4992,11 @@ static void my_hash_sort_utf8mb3_nopad(CHARSET_INFO *cs, const uchar *s, size_t
|
static void my_hash_sort_utf8mb3(CHARSET_INFO *cs, const uchar *s, size_t slen,
|
ulong *nr1, ulong *nr2)
|
{
|
- const uchar *e= s+slen;
|
/*
|
Remove end space. We have to do this to be able to compare
|
'A ' and 'A' as identical
|
*/
|
- while (e > s && e[-1] == ' ')
|
- e--;
|
+ const uchar *e= skip_trailing_space(s, slen);
|
my_hash_sort_utf8mb3_nopad(cs, s, e - s, nr1, nr2);
|
}
|
|
@@ -7436,13 +7434,11 @@ static void
|
my_hash_sort_utf8mb4(CHARSET_INFO *cs, const uchar *s, size_t slen,
|
ulong *nr1, ulong *nr2)
|
{
|
- const uchar *e= s + slen;
|
/*
|
Remove end space. We do this to be able to compare
|
'A ' and 'A' as identical
|
*/
|
- while (e > s && e[-1] == ' ')
|
- e--;
|
+ const uchar *e= skip_trailing_space(s, slen);
|
my_hash_sort_utf8mb4_nopad(cs, s, e - s, nr1, nr2);
|
}
|
- blocks
-
MDEV-22720
Improving performance of my_hash_sort_utf8(mb4)/my_strnncollsp*utf8(mb4)
-
-
Closed
{"report":{"fcp":731.5999999046326,"ttfb":181.19999980926514,"pageVisibility":"visible","entityId":88122,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"288473ef-7b61-40ec-aa49-fd6fdab22c8f","navigationType":0,"readyForUser":812.5999999046326,"redirectCount":0,"resourceLoadedEnd":685.1999998092651,"resourceLoadedStart":186.80000019073486,"resourceTiming":[{"duration":34.799999713897705,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":186.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":186.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":221.59999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":34.80000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":187.09999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":187.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":221.90000009536743,"responseStart":0,"secureConnectionStart":0},{"duration":72.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":187.30000019073486,"connectEnd":187.30000019073486,"connectStart":187.30000019073486,"domainLookupEnd":187.30000019073486,"domainLookupStart":187.30000019073486,"fetchStart":187.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":187.30000019073486,"responseEnd":259.40000009536743,"responseStart":259.40000009536743,"secureConnectionStart":187.30000019073486},{"duration":121.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":187.5,"connectEnd":187.5,"connectStart":187.5,"domainLookupEnd":187.5,"domainLookupStart":187.5,"fetchStart":187.5,"redirectEnd":0,"redirectStart":0,"requestStart":187.5,"responseEnd":309.09999990463257,"responseStart":309.09999990463257,"secureConnectionStart":187.5},{"duration":125.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":187.59999990463257,"connectEnd":187.59999990463257,"connectStart":187.59999990463257,"domainLookupEnd":187.59999990463257,"domainLookupStart":187.59999990463257,"fetchStart":187.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":187.59999990463257,"responseEnd":313.19999980926514,"responseStart":313.19999980926514,"secureConnectionStart":187.59999990463257},{"duration":125.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":187.90000009536743,"connectEnd":187.90000009536743,"connectStart":187.90000009536743,"domainLookupEnd":187.90000009536743,"domainLookupStart":187.90000009536743,"fetchStart":187.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":187.90000009536743,"responseEnd":313.59999990463257,"responseStart":313.59999990463257,"secureConnectionStart":187.90000009536743},{"duration":125.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":188.09999990463257,"connectEnd":188.09999990463257,"connectStart":188.09999990463257,"domainLookupEnd":188.09999990463257,"domainLookupStart":188.09999990463257,"fetchStart":188.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":188.09999990463257,"responseEnd":314,"responseStart":314,"secureConnectionStart":188.09999990463257},{"duration":216.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":188.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":188.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":405,"responseStart":0,"secureConnectionStart":0},{"duration":126,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":188.40000009536743,"connectEnd":188.40000009536743,"connectStart":188.40000009536743,"domainLookupEnd":188.40000009536743,"domainLookupStart":188.40000009536743,"fetchStart":188.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":188.40000009536743,"responseEnd":314.40000009536743,"responseStart":314.40000009536743,"secureConnectionStart":188.40000009536743},{"duration":216.60000038146973,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":188.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":188.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":405.30000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":126.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":188.80000019073486,"connectEnd":188.80000019073486,"connectStart":188.80000019073486,"domainLookupEnd":188.80000019073486,"domainLookupStart":188.80000019073486,"fetchStart":188.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":188.80000019073486,"responseEnd":315,"responseStart":315,"secureConnectionStart":188.80000019073486},{"duration":265.1000003814697,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":189.69999980926514,"connectEnd":189.69999980926514,"connectStart":189.69999980926514,"domainLookupEnd":189.69999980926514,"domainLookupStart":189.69999980926514,"fetchStart":189.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":189.69999980926514,"responseEnd":454.80000019073486,"responseStart":454.80000019073486,"secureConnectionStart":189.69999980926514},{"duration":361.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":189.80000019073486,"connectEnd":189.80000019073486,"connectStart":189.80000019073486,"domainLookupEnd":189.80000019073486,"domainLookupStart":189.80000019073486,"fetchStart":189.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":189.80000019073486,"responseEnd":551.1999998092651,"responseStart":551.1999998092651,"secureConnectionStart":189.80000019073486},{"duration":35.40000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":420.09999990463257,"connectEnd":420.09999990463257,"connectStart":420.09999990463257,"domainLookupEnd":420.09999990463257,"domainLookupStart":420.09999990463257,"fetchStart":420.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":420.09999990463257,"responseEnd":455.5,"responseStart":455.5,"secureConnectionStart":420.09999990463257},{"duration":226.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":458.90000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":458.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":685.0999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":225.7999997138977,"initiatorType":"link","name":"https://jira.mariadb.org/s/50bc9be5bfead1a25e72c1a9338c94f6-CDN/lu2cib/820016/12ta74/e108c7645258ccb43280ed3404e3e949/_/download/contextbatch/css/com.atlassian.jira.plugins.jira-development-integration-plugin:0,-_super,-jira.view.issue,-jira.global,-jira.general,-jira.browse.project,-project.issue.navigator,-atl.general/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":459.40000009536743,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":459.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":685.1999998092651,"responseStart":0,"secureConnectionStart":0}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":6,"responseStart":182,"responseEnd":183,"domLoading":185,"domInteractive":872,"domContentLoadedEventStart":873,"domContentLoadedEventEnd":920,"domComplete":1840,"loadEventStart":1840,"loadEventEnd":1842,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":850.5999999046326},{"name":"bigPipe.sidebar-id.end","time":851.5},{"name":"bigPipe.activity-panel-pipe-id.start","time":851.6999998092651},{"name":"bigPipe.activity-panel-pipe-id.end","time":855.0999999046326},{"name":"activityTabFullyLoaded","time":931.8000001907349}],"measures":[],"correlationId":"94f4c24ae78fbf","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":112,"dbReadsTimeInMs":15,"dbConnsTimeInMs":24,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}