Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22441

implement a generic way to change a value of a variable in a scope

Details

    Description

      Some class should store an old value and change it's value to a new/tmp value in ctor, and restore an old value in dtor.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-22438 add a function similar to std::make_scope_exit()

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            knielsen Kristian Nielsen added a comment - - edited

            midenok Ok, but I did not see any explanation for this in either this issue or in the commit comments, nor do I see serg's review anywhere. Refactoring in general is very much not appropriate for GA releases, so when there is a particular reason to do it anyway it is important that this reason is explained somewhere.

            knielsen Kristian Nielsen added a comment - - edited midenok Ok, but I did not see any explanation for this in either this issue or in the commit comments, nor do I see serg's review anywhere. Refactoring in general is very much not appropriate for GA releases, so when there is a particular reason to do it anyway it is important that this reason is explained somewhere.
            serg Sergei Golubchik added a comment -

            Wait, it must be some mistake. I wasn't a reviewer, Nikita was.

            If I'd been a reviewer, though, I'd say it could go into 10.5, being, basically, hardly worse then renaming a variable.

            serg Sergei Golubchik added a comment - Wait, it must be some mistake. I wasn't a reviewer, Nikita was. If I'd been a reviewer, though, I'd say it could go into 10.5, being, basically, hardly worse then renaming a variable.
            nikitamalyavin Nikita Malyavin added a comment -

            Correct, I was a reviewer.

            This is a code refactoring, it it not appropriate for any GA release

            I know no such policy for Foundation.

            nikitamalyavin Nikita Malyavin added a comment - Correct, I was a reviewer. This is a code refactoring, it it not appropriate for any GA release I know no such policy for Foundation.
            midenok Aleksey Midenkov added a comment - - edited

            knielsen Got it. We were discussing this in private chat. Next time I'll notify explicitly permission granted.

            P.S. And yes, Nikita was the reviewer, but first I got an approval from Sergei.

            midenok Aleksey Midenkov added a comment - - edited knielsen Got it. We were discussing this in private chat. Next time I'll notify explicitly permission granted. P.S. And yes, Nikita was the reviewer, but first I got an approval from Sergei.
            midenok Aleksey Midenkov added a comment -

            As a followup note, this code works with gcc 4.8 and it is tested not only by tests, but by bootstrap as well.

            midenok Aleksey Midenkov added a comment - As a followup note, this code works with gcc 4.8 and it is tested not only by tests, but by bootstrap as well.

            People

              midenok Aleksey Midenkov
              kevg Eugene Kosov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.