Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22355

remove unused return value of copy_back() in mariabackup

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Not a Bug
    • 10.2, 10.3, 10.4, 10.5
    • N/A
    • mariabackup
    • None

    Description

      When does copy_back() return anything else than false? It seems that the variable ret is completely redundant. Highlighted by this:

      /mariadb/10.4/extra/mariabackup/backup_copy.cc:1785:7: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]
       1785 |  bool ret;
      

      Check if there is a code which expects return value from the function and verify it's correctness.

      Attachments

        Activity

          People

            vlad.lesin Vladislav Lesin
            vlad.lesin Vladislav Lesin
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.