Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22349

MTR re-bootstrap modifies environment variable MYSQLD_BOOTSTRAP_CMD

Details

    Description

      For tests with options not compatible with the default bootstrapped datadir, MTR performs local rebootstrap, without touching the clean install.db.

      While doing so, MTR modifies MYSQLD_BOOTSTRAP_CMD environment variable. It shouldn't be happening, the variable should remain the same as it was initially, to avoid dependency on the sequence of tests. If a test uses the variable and needs it to be modified, it should be done explicitly in the test itself.

      --- /data/src/10.4/mysql-test/mysql-test-run.pl	2020-04-23 01:23:11.583215104 +0300
      +++ mysql-test-run.pl	2020-04-23 04:31:16.384303120 +0300
      @@ -3369,7 +3369,8 @@
         # ----------------------------------------------------------------------
         # export MYSQLD_BOOTSTRAP_CMD variable containing <path>/mysqld <args>
         # ----------------------------------------------------------------------
      -  $ENV{'MYSQLD_BOOTSTRAP_CMD'}= "$exe_mysqld_bootstrap " . join(" ", @$args);
      +  $ENV{'MYSQLD_BOOTSTRAP_CMD'}= "$exe_mysqld_bootstrap " . join(" ", @$args)
      +    unless defined $ENV{'MYSQLD_BOOTSTRAP_CMD'};
       
         # Extra options can come not only from the command line, but also
         # from option files or combinations. We want them on a command line
      

      Attachments

        Activity

          elenst Elena Stepanova created issue -
          elenst Elena Stepanova made changes -
          Field Original Value New Value
          Summary MTR re-bootstrap modifies datadir in MYSQLD_BOOTSTRAP_CMD MTR re-bootstrap modifies environment variable MYSQLD_BOOTSTRAP_CMD
          elenst Elena Stepanova made changes -
          Fix Version/s 10.1.45 [ 23913 ]
          Fix Version/s 10.2.32 [ 24221 ]
          Fix Version/s 10.3.23 [ 24222 ]
          Fix Version/s 10.4.13 [ 24223 ]
          Fix Version/s 10.5.3 [ 24263 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.3 [ 22126 ]
          Fix Version/s 10.4 [ 22408 ]
          Fix Version/s 10.5 [ 23123 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 107644 ] MariaDB v4 [ 157662 ]

          People

            elenst Elena Stepanova
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.