Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22348

main.default_storage_engine test uses common install.db datadir for startup

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5, 10.1, 10.2, 10.3, 10.4, 10.5
    • Fix Version/s: 10.4.13, 10.5.3
    • Component/s: Tests
    • Labels:
      None

      Description

      The test runs the MTR bootstrap command (MYSQLD_BOOTSTRAP_CMD) without changing the datadir. The command is supposed to fail, but not right away – the server will attempt to start up, so it can conflict with other tests or logic which use the same datadir in parallel (as it is common for all parallel workers). In a worse scenario, if the test doesn't work as expected, it may damage install.db datadir which is important to keep clean and healthy for resetting the environment for tests.

      The test should be using its own unique datadir.

      --- /data/src/10.4/mysql-test/main/default_storage_engine.test	2019-04-21 01:03:31.152431465 +0300
      +++ main/default_storage_engine.test	2020-04-23 04:15:50.501231748 +0300
      @@ -9,8 +9,12 @@
       # Now it *must* fail, because if InnoDB is compiled in, it is used as a default
       # storage engine. but $cmd includes --skip-innodb
       #
      +
      +--mkdir $MYSQL_TMP_DIR/default_storage_engine_data
      +
       error 1;
      -exec $cmd;
      +exec $cmd --datadir=$MYSQL_TMP_DIR/default_storage_engine_data;
       
      -echo "all ok"; # to not have zero-length result file
      +--rmdir $MYSQL_TMP_DIR/default_storage_engine_data
       
      +echo "all ok"; # to not have zero-length result file
      

        Attachments

          Activity

            People

            Assignee:
            monty Michael Widenius
            Reporter:
            elenst Elena Stepanova
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: