Details
-
Task
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
Description
Error messages inside the code
There are error messages which are composed in the code directly, particularly (but probably not only) in replication. At the very least they can appear in error logs or stderr, but possibly they can also be added to SQL errors with generic patterns, like errors passed through from an engine.
Examples:
client/mysql_upgrade.c: print_error("Version check failed. Got the following error when calling "
|
client/mysql_upgrade.c- "the 'mysql' command line client", &ds_version);
|
sql/slave.cc: errmsg= "The slave I/O thread stops because master and slave have equal \
|
sql/slave.cc-MySQL server ids; these ids must be different for replication to work (or \
|
sql/slave.cc- rli->report(ERROR_LEVEL, ER_SLAVE_RELAY_LOG_READ_FAILURE, NULL,
|
sql/slave.cc- ER_THD(thd, ER_SLAVE_RELAY_LOG_READ_FAILURE), "\
|
sql/slave.cc-Could not parse relay log event entry. The possible reasons are: the master's \
|
sql/slave.cc-binary log is corrupted (you can check this by running 'mysqlbinlog' on the \
|
sql/slave.cc-binary log), the slave's relay log is corrupted (you can check this by running \
|
sql/slave.cc:'mysqlbinlog' on the relay log), a network problem, or a bug in the master's \
|
sql/slave.cc-or slave's MySQL code. If you want to check the master's binary log or slave's \
|
sql/slave.cc-relay log, you will be able to know their names by issuing 'SHOW SLAVE STATUS' \
|
and then the corresponding test results will have to be updated, e.g.
./suite/rpl/r/rpl_server_id1.result:Last_IO_Error = 'Fatal error: The slave I/O thread stops because master and slave have equal MySQL server ids; these ids must be different for replication to work (or the -
|
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
There is no mysqld binary in 10.6, so every user will be running mariadbd. You can symlink it under any other name, but it'll still be the same mariadbd binary
Where I'm from, there is a very well mysqld binary, and no user, except perhaps mtr, runs mariadbd. There are also no symlinks.
Forgot to mention that messages that assume mysqld and command line parameters, like --tc-heuristic-recovery, have been wrong for perhaps decade or more, if used with embedded. I'm not sure what's misleading in "set server variable x to y, and restart the server", instead. If we want to add some branding into it, "restart the MariaDB server", whatever it is , mariadbd, mysqld, or libmaradbd.so . Old error messages can be improved upon, rather than mechanically replaced.
Ether "Please restart server with --tc-heuristic-recover" , or "please restart with --tc-heuristic-recover".
Or maybe omit "please" , because Unix does not say so.
"mariadbd" is misleading, because in fact, many people will be running mysqld.
In fact, I would prefer to guess executable names as little as possible, so "server" is the undisputably correct term, without marketing flavour.