Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-22053

Missing support for Debian Install Layout in C/C subproject

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2(EOL)
    • 10.5.3
    • Packaging
    • None

    Description

      Building the server package with cmake parameter -DINSTALL_LAYOUT=DEB will result in wrong installation directories for Connector/C.

      How to fix:

      --- a/cmake/mariadb_connector_c.cmake
      +++ b/cmake/mariadb_connector_c.cmake
      @@ -24,6 +24,8 @@ SET(CONC_WITH_MYSQLCOMPAT ON)
       
       IF (INSTALL_LAYOUT STREQUAL "RPM")
         SET(CONC_INSTALL_LAYOUT "RPM")
      +ELSEIF (INSTALL_LAYOUT STREQUAL "DEB")
      +  SET(CONC_INSTALL_LAYOUT "DEB")
       ELSE()
         SET(CONC_INSTALL_LAYOUT "DEFAULT")
       ENDIF()
      

      Attachments

        Issue Links

          Activity

            georg Georg Richter created issue -
            georg Georg Richter made changes -
            Field Original Value New Value
            georg Georg Richter made changes -
            otto Otto Kekäläinen made changes -
            Assignee Sergei Golubchik [ serg ] Otto Kekäläinen [ otto ]

            You can't change this on 10.2, that would change the file paths and break packaging in stable releases 10.2, 10.3 and 10.4. This is OK to do in 10.5 and I am already working on it. However, this change does not seem to be enough, I'll post you more details later.. Assigned to myself, no point in Sergei putting time on this now when he did not have time to do this in the past month. I have enough info from Georg to complete this.

            otto Otto Kekäläinen added a comment - You can't change this on 10.2, that would change the file paths and break packaging in stable releases 10.2, 10.3 and 10.4. This is OK to do in 10.5 and I am already working on it. However, this change does not seem to be enough, I'll post you more details later.. Assigned to myself, no point in Sergei putting time on this now when he did not have time to do this in the past month. I have enough info from Georg to complete this.
            otto Otto Kekäläinen made changes -
            Fix Version/s 10.5 [ 23123 ]

            It does not work because in libmariadb/install.cmake there is at the bottom the section that starts like this:

            #
            # Overwrite defaults
            #
            ...
            IF(INSTALL_PLUGINDIR)
              SET(INSTALL_PLUGINDIR_${INSTALL_LAYOUT} ${INSTALL_PLUGINDIR})
            ENDIF()
            

            The server passes a value for INSTALL_PLUGINDIR, so the INSTALL_PLUGINDIR_DEB has no function.

            otto Otto Kekäläinen added a comment - It does not work because in libmariadb/install.cmake there is at the bottom the section that starts like this: # # Overwrite defaults # ... IF(INSTALL_PLUGINDIR) SET(INSTALL_PLUGINDIR_${INSTALL_LAYOUT} ${INSTALL_PLUGINDIR}) ENDIF() The server passes a value for INSTALL_PLUGINDIR, so the INSTALL_PLUGINDIR_DEB has no function.
            otto Otto Kekäläinen added a comment - Related PR: https://github.com/mariadb-corporation/mariadb-connector-c/pull/130
            otto Otto Kekäläinen added a comment - Fixing PR: https://github.com/MariaDB/server/pull/1468/commits Follow-up PR: https://github.com/MariaDB/server/pull/1478
            otto Otto Kekäläinen added a comment - This was closed via https://github.com/MariaDB/server/commit/4bc31a904f22290801075deed949733ba2133974
            otto Otto Kekäläinen made changes -
            Fix Version/s 10.5.3 [ 24263 ]
            Fix Version/s 10.5 [ 23123 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 106173 ] MariaDB v4 [ 157493 ]

            People

              otto Otto Kekäläinen
              georg Georg Richter
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.