Uploaded image for project: 'MariaDB Connector/C'
  1. MariaDB Connector/C
  2. CONC-304

Rename the static library to libmariadb.a and other libmariadb files in a consistent manner

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • None
    • 3.1.8
    • None
    • None

    Description

      The old libmariadbclient18 package included libmariadbclient.so.18. The development package included dynamic libmariadbclient.so and static libmariadbclient.a.

      In the new Connnector/C we have dynamic libmariadb.so and libmariadbclient.a. This name mismatch is really confusing for humans using this library, and it creates conflicts in packages as files overwrite each other in wrong places. Please rename the static library to libmariadb.a.

      There has been a patch for this since 2014 (does not apply anymore): https://anonscm.debian.org/cgit/pkg-mysql/mariadb-connector-c.git/tree/debian/patches/rename_static_lib.patch?id=08de8a73c371d4fbbccb1bd8ffb739acf64867db

      Thanks!

      Related issue: MDEV-14921

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-14921 Fix mariadb/mysql client library packaging for MariaDB 10.3

          • Major - Major loss of function.
          • Closed
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22053 Missing support for Debian Install Layout in C/C subproject

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 13 older comments
            georg Georg Richter added a comment -

            Otto,

            Please correct me if I'm wrong, but the INSTALL_LAYOUT=DEB already sets the name of the static library:

            $ cmake .. -DINSTALL_LAYOUT=DEB;make -j8;ls libmariadb
            		 
            CMakeFiles  cmake_install.cmake  libmariadb.a  libmariadb.so  libmariadb.so.3  ma_client_plugin.c  Makefile  mariadbclient.def

            georg Georg Richter added a comment - Otto, Please correct me if I'm wrong, but the INSTALL_LAYOUT=DEB already sets the name of the static library: $ cmake .. -DINSTALL_LAYOUT=DEB;make -j8;ls libmariadb CMakeFiles cmake_install.cmake libmariadb.a libmariadb.so libmariadb.so.3 ma_client_plugin.c Makefile mariadbclient.def
            otto Otto Kekäläinen added a comment -

            Ok, in that case the problem is that the INSTALL_LAYOUT=DEB has never been used in https://github.com/MariaDB/server/blob/10.5/debian/rules#L78-L90

            If I've understood correctly, this INSTALL_LAYOUT applies only for the libmariadb and is defined in libmariadb/CMakeLists.txt and libmariadb/cmake/install.cmake.

            The exact same variable is also in the server CMake system and the server seems to set at CONC_INSTALL_LAYOUT variable.

            Can you georg please clarify how this is intended to work?

            Also, related to the topic of making all libmariadb files consistently named, I have a proposal at https://salsa.debian.org/mariadb-team/mariadb-10.4/-/compare/master...feature%2Flibmariadb-consistent-naming but doing it on packaging level is wrong. I was hoping you would consider this at the libmariadb build level..

            otto Otto Kekäläinen added a comment - Ok, in that case the problem is that the INSTALL_LAYOUT=DEB has never been used in https://github.com/MariaDB/server/blob/10.5/debian/rules#L78-L90 If I've understood correctly, this INSTALL_LAYOUT applies only for the libmariadb and is defined in libmariadb/CMakeLists.txt and libmariadb/cmake/install.cmake. The exact same variable is also in the server CMake system and the server seems to set at CONC_INSTALL_LAYOUT variable. Can you georg please clarify how this is intended to work? Also, related to the topic of making all libmariadb files consistently named, I have a proposal at https://salsa.debian.org/mariadb-team/mariadb-10.4/-/compare/master...feature%2Flibmariadb-consistent-naming but doing it on packaging level is wrong. I was hoping you would consider this at the libmariadb build level..
            otto Otto Kekäläinen added a comment -

            I've attached a full file listing of what files the current 10.5 git head produces, and there is no libmariadb.a yet ($ grep libmariadb.a filelist-42bf04d0b3b.log)

            otto Otto Kekäläinen added a comment - I've attached a full file listing of what files the current 10.5 git head produces, and there is no libmariadb.a yet ($ grep libmariadb.a filelist-42bf04d0b3b.log)
            otto Otto Kekäläinen added a comment -

            PR https://github.com/mariadb-corporation/mariadb-connector-c/pull/130 will fix this

            otto Otto Kekäläinen added a comment - PR https://github.com/mariadb-corporation/mariadb-connector-c/pull/130 will fix this
            otto Otto Kekäläinen added a comment -

            PR merged and issue fixed in https://github.com/mariadb-corporation/mariadb-connector-c/commit/28e1467475e5e4cc113e031291e8371d3a2a9c36

            otto Otto Kekäläinen added a comment - PR merged and issue fixed in https://github.com/mariadb-corporation/mariadb-connector-c/commit/28e1467475e5e4cc113e031291e8371d3a2a9c36

            People

              otto Otto Kekäläinen
              otto Otto Kekäläinen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.