A Spider test wrongly depends on the contents of /etc/mysql/mariadb.conf.d. On my Debian GNU/Linux Sid (unstable) system, I had files in that directory installed by the following packages:
sudo apt purge mariadb-common mariadb-client-10.3
|
./mtr spider/bugfix.return_found_rows_update
|
sudo apt install mariadb-common mariadb-client-10.3
|
./mtr spider/bugfix.return_found_rows_update
|
The two files /etc/mysql/mariadb.conf.d/50-client.cnf and /etc/mysql/mariadb.conf.d/50-mysql-clients.cnf include the setting
default-character-set = utf8mb4
|
which affects the test result. Side note: I will need the following fix in order to be able to compile Spider using clang++-10. It would fail due to {{ -Wsometimes-uninitialized}}:
diff --git a/storage/spider/spd_db_conn.cc b/storage/spider/spd_db_conn.cc
|
index afdd3a4c828..7b61678dabd 100644
|
--- a/storage/spider/spd_db_conn.cc
|
+++ b/storage/spider/spd_db_conn.cc
|
@@ -5861,6 +5861,7 @@ int spider_db_simple_action(
|
#endif
|
default:
|
DBUG_ASSERT(0);
|
+ error_num= -1;
|
break;
|
}
|
DBUG_RETURN(error_num);
|
The test fails for me with the following result difference:
CURRENT_TEST: spider/bugfix.return_found_rows_update
|
--- /mariadb/10.4/storage/spider/mysql-test/spider/bugfix/r/return_found_rows_update.result 2020-02-06 12:50:30.534105414 +0200
|
+++ /mariadb/10.4/storage/spider/mysql-test/spider/bugfix/r/return_found_rows_update.reject 2020-03-24 08:55:55.829888665 +0200
|
@@ -48,7 +48,7 @@
|
connection child2_1;
|
SELECT argument FROM mysql.general_log WHERE argument LIKE '%update %';
|
argument
|
-update `auto_test_remote`.`tbl_a` set `tm` = _latin1'12:00:00' where (`skey` = 0)
|
+update `auto_test_remote`.`tbl_a` set `tm` = _utf8mb4'12:00:00' where (`skey` = 0)
|
SELECT argument FROM mysql.general_log WHERE argument LIKE '%update %'
|
SELECT skey, dt, tm FROM tbl_a ORDER BY skey;
|
skey dt tm
|
|
mysqltest: Result length mismatch
|
If I purge the packages from Debian, then the test would pass.
Apparently, this test is not being run on buildbot, because the buildbot cross-reference has no data on this test.
{"report":{"fcp":1169,"ttfb":201.60000000149012,"pageVisibility":"visible","entityId":84482,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"8eea0b4b-73cd-410b-b5b3-264c945525f6","navigationType":0,"readyForUser":1242,"redirectCount":0,"resourceLoadedEnd":1600.3999999985099,"resourceLoadedStart":206.70000000298023,"resourceTiming":[{"duration":245.79999999701977,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":206.70000000298023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":452.5,"responseStart":0,"secureConnectionStart":0},{"duration":245.90000000596046,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":206.89999999850988,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":206.89999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":452.80000000447035,"responseStart":0,"secureConnectionStart":0},{"duration":504.20000000298023,"initiatorType":"script","name":"https://jira.mariadb.org/s/e9b27a47da5fb0f74a35acd57e9847fb-CDN/lu2bv2/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":207.10000000149012,"connectEnd":207.10000000149012,"connectStart":207.10000000149012,"domainLookupEnd":207.10000000149012,"domainLookupStart":207.10000000149012,"fetchStart":207.10000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":207.10000000149012,"responseEnd":711.3000000044703,"responseStart":711.3000000044703,"secureConnectionStart":207.10000000149012},{"duration":578.2999999970198,"initiatorType":"script","name":"https://jira.mariadb.org/s/c32eb0da7ad9831253f8397e6cc26afd-CDN/lu2bv2/820016/12ta74/2380add21a9a1006587582385952de73/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":207.20000000298023,"connectEnd":207.20000000298023,"connectStart":207.20000000298023,"domainLookupEnd":207.20000000298023,"domainLookupStart":207.20000000298023,"fetchStart":207.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":207.20000000298023,"responseEnd":785.5,"responseStart":785.5,"secureConnectionStart":207.20000000298023},{"duration":582.9000000059605,"initiatorType":"script","name":"https://jira.mariadb.org/s/bc0bcb146314416123c992714ee00ff7-CDN/lu2bv2/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":207.39999999850988,"connectEnd":207.39999999850988,"connectStart":207.39999999850988,"domainLookupEnd":207.39999999850988,"domainLookupStart":207.39999999850988,"fetchStart":207.39999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":207.39999999850988,"responseEnd":790.3000000044703,"responseStart":790.3000000044703,"secureConnectionStart":207.39999999850988},{"duration":583.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":207.70000000298023,"connectEnd":207.70000000298023,"connectStart":207.70000000298023,"domainLookupEnd":207.70000000298023,"domainLookupStart":207.70000000298023,"fetchStart":207.70000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":207.70000000298023,"responseEnd":791.2000000029802,"responseStart":791.2000000029802,"secureConnectionStart":207.70000000298023},{"duration":584,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":207.89999999850988,"connectEnd":207.89999999850988,"connectStart":207.89999999850988,"domainLookupEnd":207.89999999850988,"domainLookupStart":207.89999999850988,"fetchStart":207.89999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":207.89999999850988,"responseEnd":791.8999999985099,"responseStart":791.8999999985099,"secureConnectionStart":207.89999999850988},{"duration":650.3999999985099,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bv2/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":208.10000000149012,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":208.10000000149012,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":858.5,"responseStart":0,"secureConnectionStart":0},{"duration":584.1999999955297,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":208.20000000298023,"connectEnd":208.20000000298023,"connectStart":208.20000000298023,"domainLookupEnd":208.20000000298023,"domainLookupStart":208.20000000298023,"fetchStart":208.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":208.20000000298023,"responseEnd":792.3999999985099,"responseStart":792.3999999985099,"secureConnectionStart":208.20000000298023},{"duration":650.2000000029802,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":208.39999999850988,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":208.39999999850988,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":858.6000000014901,"responseStart":0,"secureConnectionStart":0},{"duration":585,"initiatorType":"script","name":"https://jira.mariadb.org/s/719848dd97ebe0663199f49a3936487a-CDN/lu2bv2/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":208.5,"connectEnd":208.5,"connectStart":208.5,"domainLookupEnd":208.5,"domainLookupStart":208.5,"fetchStart":208.5,"redirectEnd":0,"redirectStart":0,"requestStart":208.5,"responseEnd":793.5,"responseStart":793.5,"secureConnectionStart":208.5},{"duration":998,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":209.20000000298023,"connectEnd":209.20000000298023,"connectStart":209.20000000298023,"domainLookupEnd":209.20000000298023,"domainLookupStart":209.20000000298023,"fetchStart":209.20000000298023,"redirectEnd":0,"redirectStart":0,"requestStart":209.20000000298023,"responseEnd":1207.2000000029802,"responseStart":1207.2000000029802,"secureConnectionStart":209.20000000298023},{"duration":1391.0999999940395,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bv2/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":209.30000000447035,"connectEnd":209.30000000447035,"connectStart":209.30000000447035,"domainLookupEnd":209.30000000447035,"domainLookupStart":209.30000000447035,"fetchStart":209.30000000447035,"redirectEnd":0,"redirectStart":0,"requestStart":209.30000000447035,"responseEnd":1600.3999999985099,"responseStart":1600.3999999985099,"secureConnectionStart":209.30000000447035},{"duration":425.69999999552965,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":869.7000000029802,"connectEnd":869.7000000029802,"connectStart":869.7000000029802,"domainLookupEnd":869.7000000029802,"domainLookupStart":869.7000000029802,"fetchStart":869.7000000029802,"redirectEnd":0,"redirectStart":0,"requestStart":869.7000000029802,"responseEnd":1295.3999999985099,"responseStart":1295.3999999985099,"secureConnectionStart":869.7000000029802}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":45,"responseStart":201,"responseEnd":203,"domLoading":204,"domInteractive":1615,"domContentLoadedEventStart":1615,"domContentLoadedEventEnd":1654,"domComplete":2970,"loadEventStart":2970,"loadEventEnd":2972,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1603.8000000044703},{"name":"bigPipe.sidebar-id.end","time":1604.6000000014901},{"name":"bigPipe.activity-panel-pipe-id.start","time":1604.7000000029802},{"name":"bigPipe.activity-panel-pipe-id.end","time":1607},{"name":"activityTabFullyLoaded","time":1660.8000000044703}],"measures":[],"correlationId":"af50c54aa8849f","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":10,"dbConnsTimeInMs":19,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Bug
Major