Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21534

improve locking/waiting in log_write_up_to

    XMLWordPrintable

    Details

      Description

      On multithreaded write-intensive benchmarks, with innodb_flush_log_at_trx_comit (e.g sysbench update_index), log_write_up_to() is one of the hottest functions, and the log_sys.mutex is one of the hottest mutexes.

      This is partially due to the way ho log_sys.flush_event is used.
      Whenever there is a pending flush, a thread is going to wait on this event, and when event is signalled, it retries the flush from the start. The problem here is that when flush is done, all threads are woken, resulting in contention of log_sys.mutex. There is a lot of spurious wakeups, and retries.

      Situation can be improved e.g by using a custom synchronization primitive instead of Innodb event.

      The synchronization primitive could have 2 operations

      1. wait(wait_lsn)
      2. set(set_lsn)

      Where wait blocks current thread until set is called with set_lsn >= wait_lsn.
      Note, that seldom "pseudo-spurious" wakeup might still be necessary in order to elect new group commit leader. But set should not wakeup all of the waiting threads.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              wlad Vladislav Vaintroub
              Reporter:
              wlad Vladislav Vaintroub
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: