Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21462

main.processlist_notembedded fails to clean up, causes perfschema test failures

    XMLWordPrintable

    Details

      Description

      The test perfschema.hostcache_peer_addr times out for me almost always when I run it on 10.5. Because MDEV-20466 introduced a NUL character to the output, the difference will not be displayed by mysql-test-run.pl. I got it with diff -au:

      --- mysql-test/suite/perfschema/r/hostcache_peer_addr.result	2019-09-11 07:45:33.284745977 +0300
      +++ mysql-test/suite/perfschema/r/hostcache_peer_addr.reject	2020-01-13 14:58:37.799296135 +0200
      @@ -1,3 +1,12 @@
      +Timeout in wait_condition.inc for select count(*) = 1 from information_schema.processlist
      +Id	User	Host	db	Command	Time	State	Info	Progress
      +5	root	localhost	test	Query	30	User sleep	SELECT user FROM mysql.user WHERE user ='some' or sleep (30)	0.000
      +10	root	localhost	test	Query	0	Init	show full processlist	0.000
      +Timeout in wait_condition.inc for select count(*) <= 1 from performance_schema.threads
      +where `TYPE`='FOREGROUND'
      +Id	User	Host	db	Command	Time	State	Info	Progress
      +5	root	localhost	test	Query	60	User sleep	SELECT user FROM mysql.user WHERE user ='some' or sleep (30)	0.000
      +10	root	localhost	test	Query	0	Init	show full processlist	0.000
       flush status;
       flush hosts;
       flush user_resources;
      

      Above, there is a NUL character between ‘some’ and the closing quote. That command was added in MDEV-20466 to main.processlist_notembedded. That test does not appear to be properly cleaning up after itself.

      I can repeat this deterministically as follows:

      ./mtr --no-reorder main.processlist_notembedded perfschema.hostcache_peer_addr
      

      10.5 8576a7bacfaa4f7ac3ec86cff436e0d6e7bb3a7d

      worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019
      main.processlist_notembedded             [ pass ]     32
      perfschema.hostcache_peer_addr           [ fail ]
              Test ended at 2020-01-13 14:58:38
       
      CURRENT_TEST: perfschema.hostcache_peer_addr
      Binary files /mariadb/10.5/mysql-test/suite/perfschema/r/hostcache_peer_addr.result and /mariadb/10.5/mysql-test/suite/perfschema/r/hostcache_peer_addr.reject differ
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marko Marko Mäkelä
              Reporter:
              marko Marko Mäkelä
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: