[MDEV-21367] mysqld_safe log don't log to err.log - Jira

willhan created issue - 2019-12-20 07:37

willhan made changes - 2019-12-20 07:41

Field	Original Value	New Value
Description	mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh as the following code, the helper would always be "", so we could not log the mysqld_safe log into error log {code:java} helper=`find_in_bin mysqld_safe_helper` print_defaults=`find_in_bin my_print_defaults` # Check if helper exists $helper --help >/dev/null 2>&1 \|\| helper="" {code}	mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log. {code:java} helper=`find_in_bin mysqld_safe_helper` print_defaults=`find_in_bin my_print_defaults` # Check if helper exists $helper --help >/dev/null 2>&1 \|\| helper="" {code}

willhan made changes - 2019-12-20 07:42

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

willhan made changes - 2019-12-23 01:34

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would be "";_

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

willhan made changes - 2019-12-23 02:17

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would be "";_

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

willhan made changes - 2019-12-23 02:18

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then {color:red} ### would always be FALSE, don't log into err.log{color}
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

willhan made changes - 2019-12-23 02:19

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then {color:red} ### would always be FALSE, don't log into err.log{color}
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
{color:red}### would always be FALSE, don't log into err.log{color}{color}
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

willhan made changes - 2019-12-23 02:19

Description

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then
{color:red}### would always be FALSE, don't log into err.log{color}{color}
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

mysqld_safe.sh from https://github.com/MariaDB/server/blob/10.5/scripts/mysqld_safe.sh

As the following code in mysqld_safe, the helper would always be "". As a result, we could not record the mysqld_safe log into error log.
{code:java}
helper=`find_in_bin mysqld_safe_helper`
print_defaults=`find_in_bin my_print_defaults`

# Check if helper exists
$helper --help >/dev/null 2>&1 || helper=""
{code}

{color:red}_"$helper --help >/dev/null 2>&1" would always be 0 in mariadb, so the helper would always be "";_{color}

{code:java}
log_generic () {
  [ $dry_run -eq 1 ] && return
  priority="$1"
  shift

  msg="`date +'%y%m%d %H:%M:%S'` mysqld_safe $*"
  echo "$msg"
  case $logging in
    init) ;; # Just echo the message, don't save it anywhere
    file)
      if [ -n "$helper" ]; then ### would always be FALSE, don't log into err.log
        echo "$msg" | "$helper" "$user" log "$err_log"
      fi
    ;;
    syslog) logger -t "$syslog_tag_mysqld_safe" -p "$priority" "$*" ;;
    *)
      echo "Internal program error (non-fatal):" \
           " unknown logging method '$logging'" >&2
      ;;
  esac
}
{code}

Anel Husakovic made changes - 2020-03-05 15:37

Fix Version/s		10.2 [ 14601 ]
Fix Version/s		10.3 [ 22126 ]
Fix Version/s		10.4 [ 22408 ]
Fix Version/s		10.5 [ 23123 ]
Affects Version/s		10.2.29 [ 23911 ]
Assignee		Anel Husakovic [ anel ]

Anel Husakovic made changes - 2020-03-05 15:56

Status

Open [ 1 ]

In Progress [ 3 ]

Anel Husakovic added a comment - 2020-03-05 15:57

Indeed, introduced with 6b7918d524d5 in 10.2.

Anel Husakovic added a comment - 2020-03-05 15:57 Indeed, introduced with 6b7918d524d5 in 10.2 .

Anel Husakovic added a comment - 2020-03-06 14:11

Added to branch bb-10.2-anel-MDEV-21367.
Test cases - I supposed that if helper exist log should be saved:

anel@anel:~/mariadb/builds/RelWithDeb-10.2/usr/local/mysql$ PS4='$LINENO: ' && bash -x ./bin/mysqld_safe --defaults

564: command -v /home/anel/mariadb/builds/RelWithDeb-10.2/usr/local/mysql/bin/mysqld_safe_helper --help

565: helper_exist=0

973: log_notice 'Starting mysqld daemon with databases from /home/anel/datadir-anel'

175: log_generic daemon.notice 'Starting mysqld daemon with databases from /home/anel/datadir-anel'

149: '[' 0 -eq 1 ']'

150: priority=daemon.notice

151: shift

1153: date '+%y%m%d %H:%M:%S'   # THIS IS WEIRD IN SHOWING THE NUMBER (bash)

153: msg='200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel'

154: echo '200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel'

200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel

155: case $logging in

158: '[' 0 -eq 0 ']'

159: echo '200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel'

159: /home/anel/mariadb/builds/RelWithDeb-10.2/usr/local/mysql/bin/mysqld_safe_helper mysql log /home/anel/datadir-anel/mysqld_safe_anel.err

Stop the mysqld_safe daemon and see results:

anel@anel:~/mariadb/builds/RelWithDeb-10.2/usr/local/mysql$ cat ~/datadir-anel/mysqld_safe_anel.err | grep mysqld_safe

200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel

200306 15:01:42 mysqld_safe mysqld from pid file /home/anel/datadir-anel/anel.pid ended

serg or cvicentiu, can you please take a look ?

Anel Husakovic added a comment - 2020-03-06 14:11 Added to branch bb-10.2-anel-MDEV-21367 . Test cases - I supposed that if helper exist log should be saved: anel@anel:~ /mariadb/builds/RelWithDeb-10 .2 /usr/local/mysql $ PS4= '$LINENO: ' && bash -x . /bin/mysqld_safe --defaults . 564: command - v /home/anel/mariadb/builds/RelWithDeb-10 .2 /usr/local/mysql/bin/mysqld_safe_helper --help 565: helper_exist=0 . 973: log_notice 'Starting mysqld daemon with databases from /home/anel/datadir-anel' 175: log_generic daemon.notice 'Starting mysqld daemon with databases from /home/anel/datadir-anel' 149: '[' 0 - eq 1 ']' 150: priority=daemon.notice 151: shift 1153: date '+%y%m%d %H:%M:%S' # THIS IS WEIRD IN SHOWING THE NUMBER (bash) 153: msg= '200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel' 154: echo '200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel' 200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel 155: case $logging in 158: '[' 0 - eq 0 ']' 159: echo '200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel' 159: /home/anel/mariadb/builds/RelWithDeb-10 .2 /usr/local/mysql/bin/mysqld_safe_helper mysql log /home/anel/datadir-anel/mysqld_safe_anel .err Stop the mysqld_safe daemon and see results: anel@anel:~ /mariadb/builds/RelWithDeb-10 .2 /usr/local/mysql $ cat ~ /datadir-anel/mysqld_safe_anel .err | grep mysqld_safe 200306 14:59:37 mysqld_safe Starting mysqld daemon with databases from /home/anel/datadir-anel 200306 15:01:42 mysqld_safe mysqld from pid file /home/anel/datadir-anel/anel .pid ended serg or cvicentiu , can you please take a look ?

Anel Husakovic made changes - 2020-03-06 14:11

Status

In Progress [ 3 ]

Stalled [ 10000 ]

Anel Husakovic made changes - 2020-03-06 14:11

Assignee	Anel Husakovic [ anel ]	Vicențiu Ciorbaru [ cvicentiu ]
Status	Stalled [ 10000 ]	In Review [ 10002 ]

Anel Husakovic added a comment - 2020-12-07 09:06

Pushed to 10.2 with eb7b14ec9a4e0

Anel Husakovic added a comment - 2020-12-07 09:06 Pushed to 10.2 with eb7b14ec9a4e0

Anel Husakovic made changes - 2020-12-07 09:06

Component/s		Scripts & Clients [ 11002 ]
Fix Version/s		10.2.37 [ 25112 ]
Fix Version/s		10.3.28 [ 25111 ]
Fix Version/s		10.4.18 [ 25110 ]
Fix Version/s		10.5.9 [ 25109 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Fix Version/s	10.4 [ 22408 ]
Fix Version/s	10.5 [ 23123 ]
Assignee	Vicențiu Ciorbaru [ cvicentiu ]	Anel Husakovic [ anel ]
Resolution		Fixed [ 1 ]
Status	In Review [ 10002 ]	Closed [ 6 ]

Sergei Golubchik made changes - 2021-12-06 21:50

Workflow

MariaDB v3 [ 102605 ]

MariaDB v4 [ 157133 ]

MariaDB Server

mysqld_safe log don't log to err.log

Details

Description

Attachments

Activity

People

Dates

Git Integration