Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-21317

mysqlhotcopy and transaction_registry table

Details

    Description

      See also (original report):
      http://bugs.debian.org/946671

      Using mysqlhotcopy, I received the error:

      DBD::mysql::db do failed: You can't use locks with log tables at /usr/bin/mysqlhotcopy line 545.

      (Your line number may differ: I use my "own" mysqlhotcopy, as per
      http://bugs.debian.org/735014 .)

      This seems related to the new transaction_registry table
      as suggested in
      https://mariadb.com/kb/en/library/mysqldump/
      that says:
      mysqldump in MariaDB 10.3 includes logic to cater for the
      mysql.transaction_registry table. ...

      My patch for this issue, below.

      Cheers, Paul

      --- /usr/bin/mysqlhotcopy.OLD   2017-12-26 09:11:27.000000000 +1100
      		 
      +++ /usr/bin/mysqlhotcopy       2019-12-13 21:10:34.225611502 +1100
      		 
      @@ -317,8 +317,24 @@
      		 
           ## keep in sync with mysqldump.
      		 
           if ($db =~ m/^mysql$/i)
      		 
           {
      		 
      +#####
      		 
      +#      @dbh_base_tables = grep 
      +#        { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
      		 
      +#####
      		 
      +# PSz 13 Dec 2019
      		 
      +# Skip transaction_registry also.
      		 
      +# See also:
      		 
      +#   https://bugs.mysql.com/bug.php?id=43594
      		 
      +#   https://bugs.debian.org/574514
      		 
      +# and see
      		 
      +#   https://mariadb.com/kb/en/library/mysqldump/
      		 
      +# that says:
      		 
      +#   mysqldump in MariaDB 10.3 includes logic to cater for the mysql.transaction_registry table. ...
      		 
      +# but I guess they forgot about mysqlhotcopy.
      		 
      +#####
      		 
             @dbh_base_tables = grep 
      -        { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
      		 
      +        { !/^(apply_status|schema|general_log|slow_log|transaction_registry)$/ } @dbh_base_tables
      		 
      +#####
      		 
           }
      		 
       
           ## generate regex for tables/files

      –
      Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
      School of Mathematics and Statistics University of Sydney Australia

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          psz Paul Szabo created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Description See also (original report):
          http://bugs.debian.org/946671

          Using mysqlhotcopy, I received the error:

            DBD::mysql::db do failed: You can't use locks with log tables at /usr/bin/mysqlhotcopy line 545.

          (Your line number may differ: I use my "own" mysqlhotcopy, as per
          http://bugs.debian.org/735014 .)

          This seems related to the new transaction_registry table
          as suggested in
            https://mariadb.com/kb/en/library/mysqldump/
          that says:
            mysqldump in MariaDB 10.3 includes logic to cater for the
            mysql.transaction_registry table. ...

          My patch for this issue, below.

          Cheers, Paul


          --- /usr/bin/mysqlhotcopy.OLD 2017-12-26 09:11:27.000000000 +1100
          +++ /usr/bin/mysqlhotcopy 2019-12-13 21:10:34.225611502 +1100
          @@ -317,8 +317,24 @@
               ## keep in sync with mysqldump.
               if ($db =~ m/^mysql$/i)
               {
          +#####
          +# @dbh_base_tables = grep
          +# { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
          +#####
          +# PSz 13 Dec 2019
          +# Skip transaction_registry also.
          +# See also:
          +# https://bugs.mysql.com/bug.php?id=43594
          +# https://bugs.debian.org/574514
          +# and see
          +# https://mariadb.com/kb/en/library/mysqldump/
          +# that says:
          +# mysqldump in MariaDB 10.3 includes logic to cater for the mysql.transaction_registry table. ...
          +# but I guess they forgot about mysqlhotcopy.
          +#####
                 @dbh_base_tables = grep
          - { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
          + { !/^(apply_status|schema|general_log|slow_log|transaction_registry)$/ } @dbh_base_tables
          +#####
               }
           
               ## generate regex for tables/files


          --
          Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
          School of Mathematics and Statistics University of Sydney Australia
          		See also (original report):
          http://bugs.debian.org/946671

          Using mysqlhotcopy, I received the error:

            DBD::mysql::db do failed: You can't use locks with log tables at /usr/bin/mysqlhotcopy line 545.

          (Your line number may differ: I use my "own" mysqlhotcopy, as per
          http://bugs.debian.org/735014 .)

          This seems related to the new transaction_registry table
          as suggested in
            https://mariadb.com/kb/en/library/mysqldump/
          that says:
            mysqldump in MariaDB 10.3 includes logic to cater for the
            mysql.transaction_registry table. ...

          My patch for this issue, below.

          Cheers, Paul

          {code:diff}
          --- /usr/bin/mysqlhotcopy.OLD 2017-12-26 09:11:27.000000000 +1100
          +++ /usr/bin/mysqlhotcopy 2019-12-13 21:10:34.225611502 +1100
          @@ -317,8 +317,24 @@
               ## keep in sync with mysqldump.
               if ($db =~ m/^mysql$/i)
               {
          +#####
          +# @dbh_base_tables = grep
          +# { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
          +#####
          +# PSz 13 Dec 2019
          +# Skip transaction_registry also.
          +# See also:
          +# https://bugs.mysql.com/bug.php?id=43594
          +# https://bugs.debian.org/574514
          +# and see
          +# https://mariadb.com/kb/en/library/mysqldump/
          +# that says:
          +# mysqldump in MariaDB 10.3 includes logic to cater for the mysql.transaction_registry table. ...
          +# but I guess they forgot about mysqlhotcopy.
          +#####
                 @dbh_base_tables = grep
          - { !/^(apply_status|schema|general_log|slow_log)$/ } @dbh_base_tables
          + { !/^(apply_status|schema|general_log|slow_log|transaction_registry)$/ } @dbh_base_tables
          +#####
               }
           
               ## generate regex for tables/files
          {code}

          --
          Paul Szabo psz@maths.usyd.edu.au http://www.maths.usyd.edu.au/u/psz/
          School of Mathematics and Statistics University of Sydney Australia
          serg Sergei Golubchik made changes -
          Assignee Aleksey Midenkov [ midenok ]
          otto Otto Kekäläinen made changes -
          Labels Patch patch
          midenok Aleksey Midenkov made changes -
          Labels Patch patch patch
          midenok Aleksey Midenkov made changes -
          Labels patch patch trx-versioning
          midenok Aleksey Midenkov made changes -
          Fix Version/s 10.3 [ 22126 ]
          midenok Aleksey Midenkov made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          midenok Aleksey Midenkov added a comment -

          Thanks for the contribution! Pushed to 10.3.

          midenok Aleksey Midenkov added a comment - Thanks for the contribution! Pushed to 10.3.
          midenok Aleksey Midenkov made changes -
          Fix Version/s 10.3.23 [ 24222 ]
          Fix Version/s 10.4.13 [ 24223 ]
          Fix Version/s 10.3 [ 22126 ]
          Resolution Fixed [ 1 ]
          Status In Progress [ 3 ] Closed [ 6 ]
          otto Otto Kekäläinen added a comment -

          Thanks midenok for applying this in https://github.com/mariadb/server/commit/74deeaee342c901c92b91d12033771716a373d8e.patch

          The commit however states your name as Author, and real Author is only in commit message. Next time when you apply patches on behalf of somebody else, please use `git commit --author "Paul Szabo <psz@maths.usyd.edu.au>"` (or whatever the next author is). Thanks!

          otto Otto Kekäläinen added a comment - Thanks midenok for applying this in https://github.com/mariadb/server/commit/74deeaee342c901c92b91d12033771716a373d8e.patch The commit however states your name as Author, and real Author is only in commit message. Next time when you apply patches on behalf of somebody else, please use `git commit --author "Paul Szabo <psz@maths.usyd.edu.au>"` (or whatever the next author is). Thanks!
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 101884 ] MariaDB v4 [ 157100 ]

          People

            midenok Aleksey Midenkov
            psz Paul Szabo
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.