Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.2.27, 10.1.41, 10.3.18, 10.4.8
-
None
Description
The wsrep_sst_mariabackup SST script is executed with the bash '-e' option, so every execution of a command that returns a non-zero exit status will terminate the script, unless wrapped in a "set -e" / "set +e" block.
This is not used when trying to determine the absolute path to mariabackup, so when "which" fails here (which it does silently), the SST script will fail at this point, too:
INNOBACKUPEX_BIN=$(which mariabackup)
|
I propose to change the line above to:
set +e
|
INNOBACKUPEX_BIN=$(which mariabackup)
|
if test -z $INNOBACKUPEX_BIN
|
then
|
wsrep_log_error 'mariabackup binary not found in $PATH'
|
exit 42
|
fi
|
set -e
|
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Affects Version/s | 10.3.18 [ 23719 ] | |
| Affects Version/s | 10.2.27 [ 23717 ] | |
| Affects Version/s | 10.1.41 [ 23406 ] |
| Assignee | Jan Lindström [ jplindst ] |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| issue.field.resolutiondate | 2019-11-08 09:03:45.0 | 2019-11-08 09:03:45.82 |
| Fix Version/s | 10.1.43 [ 23703 ] | |
| Fix Version/s | 10.2.29 [ 23911 ] | |
| Fix Version/s | 10.3.20 [ 23909 ] | |
| Fix Version/s | 10.4.10 [ 23907 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Fix Version/s | 10.1 [ 16100 ] | |
| Fix Version/s | 10.3 [ 22126 ] | |
| Fix Version/s | 10.4 [ 22408 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 100863 ] | MariaDB v4 [ 156940 ] |
Introduced by this change:
https://github.com/MariaDB/server/commit/cb85803c459ceae885538d941b3456a7b6fef919