[MDEV-20981] wsrep_sst_mariabackup fails silently when mariabackup is not installed Created: 2019-11-05  Updated: 2019-11-08  Resolved: 2019-11-08

Status: Closed
Project: MariaDB Server
Component/s: Galera SST
Affects Version/s: 10.2.27, 10.1.41, 10.3.18, 10.4.8
Fix Version/s: 10.2.29, 10.1.43, 10.3.20, 10.4.10

Type: Bug Priority: Major
Reporter: Hartmut Holzgraefe Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 1
Labels: None


 Description   

The wsrep_sst_mariabackup SST script is executed with the bash '-e' option, so every execution of a command that returns a non-zero exit status will terminate the script, unless wrapped in a "set -e" / "set +e" block.

This is not used when trying to determine the absolute path to mariabackup, so when "which" fails here (which it does silently), the SST script will fail at this point, too:

INNOBACKUPEX_BIN=$(which mariabackup)

I propose to change the line above to:

set +e
INNOBACKUPEX_BIN=$(which mariabackup)
if test -z $INNOBACKUPEX_BIN
then
  wsrep_log_error 'mariabackup binary not found in $PATH'
  exit 42
fi
set -e



 Comments   
Comment by Hartmut Holzgraefe [ 2019-11-05 ]

Introduced by this change:

https://github.com/MariaDB/server/commit/cb85803c459ceae885538d941b3456a7b6fef919

Comment by Hartmut Holzgraefe [ 2019-11-05 ]

https://github.com/MariaDB/server/pull/1406

Generated at Thu Feb 08 09:03:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.