Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20972

`or` alterative operator breaking windows build

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.4(EOL)
    • 10.4.11
    • Server
    • None
    • Windows 10, vs 2015

    Description

      Commit b44171428ab2ea25db82f7cd27349e67812e4921 introduced the `or` operator in sql/item_subselect.cc:126 . This has caused us some problems with building on windows with vs2015. I searched the code base and could not find another use of `or` as the alternative operator.

      I propose removing the user of `or` and using the traditional `||`. I'll push a PR against 10.4 shortly to address this.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21070 Build Error in MSVC

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR #1405

          Activity

            Transition Time In Source Status Execution Times
            Anel Husakovic made transition -
            Open Confirmed
            		17d 1h 48m 1
            Anel Husakovic made transition -
            Confirmed In Progress
            		2s 1
            Anel Husakovic made transition -
            In Progress Stalled
            		33s 1
            Anel Husakovic made transition -
            Stalled In Review
            		7s 1
            Anel Husakovic made transition -
            In Review Closed
            		14h 22m 1

            People

              anel Anel Husakovic
              Shelnutt2 Seth Shelnutt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.