Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-20972

`or` alterative operator breaking windows build

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • 10.4(EOL)
    • 10.4.11
    • Server
    • None
    • Windows 10, vs 2015

    Description

      Commit b44171428ab2ea25db82f7cd27349e67812e4921 introduced the `or` operator in sql/item_subselect.cc:126 . This has caused us some problems with building on windows with vs2015. I searched the code base and could not find another use of `or` as the alternative operator.

      I propose removing the user of `or` and using the traditional `||`. I'll push a PR against 10.4 shortly to address this.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21070 Build Error in MSVC

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          links to

          Web Link PR #1405

          Activity

            Ascending order - Click to sort in descending order
            anel Anel Husakovic added a comment -

            Hi Shelnutt2,
            what was your configuration ?
            Did you try to run in Debug mode ?

            anel Anel Husakovic added a comment - Hi Shelnutt2 , what was your configuration ? Did you try to run in Debug mode ?
            Shelnutt2 Seth Shelnutt added a comment -

            Hello @Anel Husakovic . We are building in release mode, I did not try debug mode but it doesn't appear the code is wrapped in any preprocessors to change debug vs release build. While the Microsoft docs say that the `/Za` flag should allow the `or` operator this compile flag did not effect the build. Since there was no other use of the or operator in the entire MariaDB codebase I pushed the patch to replace it with `||`.

            Shelnutt2 Seth Shelnutt added a comment - Hello @Anel Husakovic . We are building in release mode, I did not try debug mode but it doesn't appear the code is wrapped in any preprocessors to change debug vs release build. While the Microsoft docs say that the `/Za` flag should allow the `or` operator this compile flag did not effect the build. Since there was no other use of the or operator in the entire MariaDB codebase I pushed the patch to replace it with `||`.
            anel Anel Husakovic added a comment -

            Yes Seth, I have seen, will check some further tests and let you know soon.
            My question was redirected on MDEV-21121.

            anel Anel Husakovic added a comment - Yes Seth, I have seen, will check some further tests and let you know soon. My question was redirected on MDEV-21121 .

            People

              anel Anel Husakovic
              Shelnutt2 Seth Shelnutt
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.